Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(TFECO-7366) Stacks: parse terraform-sources.json to support remote component sources #1836

Merged
merged 8 commits into from
Nov 28, 2024
Merged

(TFECO-7366) Stacks: parse terraform-sources.json to support remote component sources #1836

merged 8 commits into from
Nov 28, 2024

Conversation

ansgarm
Copy link
Member

@ansgarm ansgarm commented Sep 25, 2024 •
edited
Loading

@ansgarm ansgarm changed the title wip stacks: parse terraform-sources.json to support remote component sources Sep 25, 2024
@ansgarm ansgarm mentioned this pull request Sep 25, 2024
Merged
@ansgarm ansgarm force-pushed the parse-terraform-sources branch from 180223e to 6f517c2 Compare October 1, 2024 13:47
@ansgarm ansgarm changed the title stacks: parse terraform-sources.json to support remote component sources (TFECO-7366) Stacks: parse terraform-sources.json to support remote component sources Oct 16, 2024
@ansgarm ansgarm force-pushed the parse-terraform-sources branch from fe982b4 to b491749 Compare October 28, 2024 08:03
@ansgarm ansgarm marked this pull request as ready for review October 28, 2024 08:13
@ansgarm ansgarm requested a review from a team as a code owner October 28, 2024 08:13
@ansgarm ansgarm force-pushed the parse-terraform-sources branch 2 times, most recently from 6bcb15e to 21628e9 Compare October 29, 2024 12:51
@ansgarm ansgarm mentioned this pull request Oct 29, 2024
Merged
dbanck
dbanck reviewed Oct 30, 2024
View reviewed changes
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I left some comments

internal/features/rootmodules/jobs/terraform_sources.go Outdated Show resolved Hide resolved
internal/features/rootmodules/state/installed_modules.go Show resolved Hide resolved
internal/features/rootmodules/state/root_store.go Outdated Show resolved Hide resolved
internal/terraform/datadir/terraform_sources.go Outdated Show resolved Hide resolved
@dbanck dbanck mentioned this pull request Nov 7, 2024
Merged
@ansgarm ansgarm force-pushed the parse-terraform-sources branch from e57e03e to b599781 Compare November 15, 2024 11:06
@ansgarm ansgarm force-pushed the parse-terraform-sources branch from b599781 to 2679660 Compare November 27, 2024 15:09
@ansgarm ansgarm requested a review from dbanck November 27, 2024 15:10
@ansgarm ansgarm force-pushed the parse-terraform-sources branch from 2679660 to ffb9f05 Compare November 28, 2024 09:00
@ansgarm ansgarm force-pushed the parse-terraform-sources branch from ffb9f05 to 408553e Compare November 28, 2024 09:31
@ansgarm ansgarm requested a review from dbanck November 28, 2024 09:40
@ansgarm ansgarm force-pushed the parse-terraform-sources branch from a2ad531 to 4204db3 Compare November 28, 2024 09:56
dbanck
dbanck approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ansgarm ansgarm force-pushed the parse-terraform-sources branch from b8afd5f to 9bdeeef Compare November 28, 2024 12:27
@ansgarm ansgarm force-pushed the parse-terraform-sources branch from 9bdeeef to 1a6d5cd Compare November 28, 2024 12:37
@ansgarm ansgarm requested a review from dbanck November 28, 2024 12:38
@ansgarm ansgarm force-pushed the parse-terraform-sources branch from 1a6d5cd to 55dd53f Compare November 28, 2024 12:49
@ansgarm ansgarm merged commit 0a91911 into main Nov 28, 2024
22 checks passed
@ansgarm ansgarm deleted the parse-terraform-sources branch November 28, 2024 15:17
@BrewTestBot BrewTestBot mentioned this pull request Dec 11, 2024
Merged
@ansgarm ansgarm mentioned this pull request Dec 19, 2024
Merged
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dbanck dbanck dbanck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ansgarm @dbanck