Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky initialize handler tests #1883

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Fix flaky initialize handler tests #1883

merged 3 commits into from
Dec 2, 2024

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Dec 2, 2024

This is PR #2 of the "reducing CI flakiness" project.

We now wait for all directories found to be persisted in state during the workspace walk. This ensures that later operations will have access to the complete state.

UX Before

image

Related

@dbanck dbanck added the bug Something isn't working label Dec 2, 2024
@dbanck dbanck marked this pull request as ready for review December 2, 2024 12:43
@dbanck dbanck requested a review from a team as a code owner December 2, 2024 12:43
Copy link
Member

@ansgarm ansgarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbanck dbanck merged commit e4971fd into main Dec 2, 2024
23 checks passed
@dbanck dbanck deleted the b-fix-init-tests branch December 2, 2024 13:16
Copy link

github-actions bot commented Jan 2, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants