Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tftypes package to root of module. #70

Merged
merged 2 commits into from
Mar 31, 2021
Merged

Move tftypes package to root of module. #70

merged 2 commits into from
Mar 31, 2021

Conversation

paddycarver
Copy link
Contributor

Rather than making tftypes a namespaced package and having one per
protocol version, we're going to use the same implementation across
protocol versions. To reflect this, move tftypes to the root of the
module, not namespaced by a protocol version, and rewrite the imports
for it.

@paddycarver
Move tftypes package to root of module.
fe38b3e 
Rather than making tftypes a namespaced package and having one per
protocol version, we're going to use the same implementation across
protocol versions. To reflect this, move tftypes to the root of the
module, not namespaced by a protocol version, and rewrite the imports
for it.
@paddycarver paddycarver added the breaking-change This will impact or improve our compatibility posture label Mar 31, 2021
@paddycarver paddycarver requested a review from a team March 31, 2021 15:55
@paddycarver paddycarver merged commit 014db87 into main Mar 31, 2021
@paddycarver paddycarver deleted the paddy_top_level_tftypes branch March 31, 2021 16:53
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kmoe kmoe kmoe approved these changes

Assignees
No one assigned
Labels
breaking-change This will impact or improve our compatibility posture
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paddycarver @kmoe