Don't panic when String() is called on nil Value{} #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, attempting to call val.String() where val := Value{} results
in a panic.
While a Value without a type will not be returned from NewValue except
in case of error, Value{} is likely to appear in consumer code from time
to time, e.g. in tests, as it is the nil value of the struct. Define an
arbitrary string representation for Value{}.
Backwards-compatible because this was previously undefined behaviour.
paddycarver
reviewed
Jun 11, 2021
paddycarver
approved these changes
Jun 16, 2021
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While a
Valuewithout atypwill not be returned fromNewValueexcept in case of error,Value{}is likely to appear in consumer code from time to time, e.g. in tests, as it is the nil value of the struct.This PR defines an arbitrary string representation for
Value{}. The only non-trivial question here is what it should be.Backwards-compatible because this was previously undefined behaviour.
Bonus
This PR also adds lots of tests for
Value.String(), which had little test coverage.