Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic in tftypes.Value.Equal. #90

Merged
merged 2 commits into from
Jun 24, 2021
Merged

Conversation

paddycarver
Copy link
Contributor

If a non-empty tftypes.Value was compared to the empty value of a
tftypes.Value, it would cause a panic. Add tests to show the issue and
fix it.

If a non-empty tftypes.Value was compared to the empty value of a
tftypes.Value, it would cause a panic. Add tests to show the issue and
fix it.
@paddycarver paddycarver added the bug Something isn't working label Jun 24, 2021
@paddycarver paddycarver requested a review from a team June 24, 2021 16:51
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

@paddycarver paddycarver merged commit 9568d68 into main Jun 24, 2021
@paddycarver paddycarver deleted the paddy_panic_empty_value_equal branch June 24, 2021 17:03
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants