r/backup_vault_notifications - Add new resource

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #8727

Release note for CHANGELOG:

resource_aws_backup_vault_notifications; add new resource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAwsBackupVaultNotification_'
--- PASS: TestAccAwsBackupVaultNotification_basic (54.58s)
--- PASS: TestAccAwsBackupVaultNotification_disappears (53.07s)

[ewbankkit]

Verified acceptance tests:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAwsBackupVaultNotification_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsBackupVaultNotification_ -timeout 120m
=== RUN   TestAccAwsBackupVaultNotification_basic
=== PAUSE TestAccAwsBackupVaultNotification_basic
=== RUN   TestAccAwsBackupVaultNotification_disappears
=== PAUSE TestAccAwsBackupVaultNotification_disappears
=== CONT  TestAccAwsBackupVaultNotification_basic
=== CONT  TestAccAwsBackupVaultNotification_disappears
--- PASS: TestAccAwsBackupVaultNotification_disappears (29.02s)
--- PASS: TestAccAwsBackupVaultNotification_basic (29.67s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	29.712s

[giuliocalzolari]

any ETA to merge it?

[slikk66]

+1 where's the merge?

[giuliocalzolari]

+1

[ericrichtert]

please merge this one

[ewbankkit]

@DrFaust92 Could you please add a test sweeper for aws_backup_vault_notification resources and add it as an upstream dependency for sweeping SNS topics?
Thanks.

[DrFaust92]

Added sweeper + dependency

[ewbankkit]

Need to make fmt.

[DrFaust92]

rebased

[ewbankkit]

@DrFaust92 I got these errors when running the acceptance tests:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAwsBackupVaultNotification_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsBackupVaultNotification_ -timeout 120m
=== RUN   TestAccAwsBackupVaultNotification_basic
=== PAUSE TestAccAwsBackupVaultNotification_basic
=== RUN   TestAccAwsBackupVaultNotification_disappears
=== PAUSE TestAccAwsBackupVaultNotification_disappears
=== CONT  TestAccAwsBackupVaultNotification_basic
=== CONT  TestAccAwsBackupVaultNotification_disappears
=== CONT  TestAccAwsBackupVaultNotification_basic
    resource_aws_backup_vault_notifications_test.go:78: Step 1/2 error: terraform failed: exit status 1
        
        stderr:
        
        Error: invalid value for backup_vault_name (must consist of lowercase letters, numbers, and hyphens.)
        
          on config411170255/terraform_plugin_test.tf line 39, in resource "aws_backup_vault_notifications" "test":
          39:   backup_vault_name   = aws_backup_vault.test.name
        
        
=== CONT  TestAccAwsBackupVaultNotification_disappears
    resource_aws_backup_vault_notifications_test.go:104: Step 1/1 error: terraform failed: exit status 1
        
        stderr:
        
        Error: invalid value for backup_vault_name (must consist of lowercase letters, numbers, and hyphens.)
        
          on config601163989/terraform_plugin_test.tf line 39, in resource "aws_backup_vault_notifications" "test":
          39:   backup_vault_name   = aws_backup_vault.test.name
        
        
--- FAIL: TestAccAwsBackupVaultNotification_basic (4.95s)
--- FAIL: TestAccAwsBackupVaultNotification_disappears (5.00s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	5.047s
FAIL
GNUmakefile:27: recipe for target 'testacc' failed
make: *** [testacc] Error 1

[DrFaust92]

Probably got to do with my change to validation, reverted and tested it to work.

[eharris-r7]

+1 Any idea when this will be merged?

[breathingdust]

LGTM! 🚀 Thanks @DrFaust92

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws TESTARGS='-run=TestAccAwsBackupVaultNotification_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsBackupVaultNotification_ -timeout 120m
=== RUN   TestAccAwsBackupVaultNotification_basic
=== PAUSE TestAccAwsBackupVaultNotification_basic
=== RUN   TestAccAwsBackupVaultNotification_disappears
=== PAUSE TestAccAwsBackupVaultNotification_disappears
=== CONT  TestAccAwsBackupVaultNotification_basic
=== CONT  TestAccAwsBackupVaultNotification_disappears
    resource_aws_backup_vault_notifications_test.go:104: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAwsBackupVaultNotification_disappears (16.45s)
--- PASS: TestAccAwsBackupVaultNotification_basic (17.54s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	18.860s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TEST=./aws TESTARGS='-run=TestAccAwsBackupVaultNotification_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsBackupVaultNotification_ -timeout 120m
=== RUN   TestAccAwsBackupVaultNotification_basic
=== PAUSE TestAccAwsBackupVaultNotification_basic
=== RUN   TestAccAwsBackupVaultNotification_disappears
=== PAUSE TestAccAwsBackupVaultNotification_disappears
=== CONT  TestAccAwsBackupVaultNotification_basic
=== CONT  TestAccAwsBackupVaultNotification_disappears
    resource_aws_backup_vault_notifications_test.go:104: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAwsBackupVaultNotification_disappears (11.39s)
--- PASS: TestAccAwsBackupVaultNotification_basic (12.57s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	13.877s

[ghost]

This has been released in version 3.9.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!