Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/ses_receipt_rule - add arn attribute + validations #13960

Merged
merged 11 commits into from
Feb 11, 2021

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13624

Release note for CHANGELOG:

resouce_aws_ses_receipt_rule: add arn attribute
resouce_aws_ses_receipt_rule: add plan time validations for `name`, `tls_policy`, `add_header_action.header_name`,
`add_header_action.header_value`,  `bounce_action.topic_arn`, `lambda_action.function_arn`, `lambda_action.topic_arn`,
`lambda_action.invocation_type`, `s3_action,topic_arn`, `sns_action.topic_arn`, `stop_action.scope`, `stop_action.topic_arn`,
`workmail_action.topic_arn`, `workmail_action.organization_arn`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSESReceiptRule_'
--- PASS: TestAccAWSSESReceiptRule_basic (53.48s)
--- PASS: TestAccAWSSESReceiptRule_s3Action (96.70s)
--- PASS: TestAccAWSSESReceiptRule_actions (53.84s)
--- PASS: TestAccAWSSESReceiptRule_disappears (74.57s)
--- PASS: TestAccAWSSESReceiptRule_order (61.74s)

@DrFaust92 DrFaust92 requested a review from a team June 26, 2020 20:11
@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/ses Issues and PRs that pertain to the ses service. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 26, 2020
@ghost ghost added the provider Pertains to the provider itself, rather than any interaction with AWS. label Jul 25, 2020
@DrFaust92 DrFaust92 force-pushed the r/ses_receipt_rule_arn branch from 662f92b to e2e85fc Compare July 25, 2020 13:30
@DrFaust92 DrFaust92 force-pushed the r/ses_receipt_rule_arn branch from e2e85fc to 090f7ce Compare November 12, 2020 19:37
@DrFaust92 DrFaust92 requested a review from a team as a code owner November 12, 2020 19:37
Base automatically changed from master to main January 23, 2021 00:58
@DrFaust92 DrFaust92 force-pushed the r/ses_receipt_rule_arn branch from 3d6f48b to e43b9ad Compare February 11, 2021 15:16
@bflad bflad self-assigned this Feb 11, 2021
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 11, 2021
.changelog/13960.txt Outdated Show resolved Hide resolved
.changelog/13960.txt Outdated Show resolved Hide resolved
aws/resource_aws_ses_receipt_rule.go Outdated Show resolved Hide resolved
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🚀

References:

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSSESReceiptRule_actions (16.74s)
--- PASS: TestAccAWSSESReceiptRule_basic (17.25s)
--- PASS: TestAccAWSSESReceiptRule_order (19.23s)
--- PASS: TestAccAWSSESReceiptRule_disappears (24.55s)
--- PASS: TestAccAWSSESReceiptRule_s3Action (29.53s)

Output from acceptance testing in AWS GovCloud (US):

--- SKIP: TestAccAWSSESReceiptRule_disappears (2.97s)
--- SKIP: TestAccAWSSESReceiptRule_order (2.97s)
--- SKIP: TestAccAWSSESReceiptRule_s3Action (2.97s)
--- SKIP: TestAccAWSSESReceiptRule_actions (3.01s)
--- SKIP: TestAccAWSSESReceiptRule_basic (3.25s)

@bflad bflad merged commit 92f2f19 into hashicorp:main Feb 11, 2021
@github-actions github-actions bot added this to the v3.28.0 milestone Feb 11, 2021
@ghost
Copy link

ghost commented Feb 12, 2021

This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 14, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 14, 2021
@DrFaust92 DrFaust92 deleted the r/ses_receipt_rule_arn branch April 15, 2021 10:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. service/ses Issues and PRs that pertain to the ses service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants