Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/elastic_transcoder_pipeline - add validations #13973

Merged
merged 12 commits into from
Feb 12, 2021

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #11872, #13820

Release note for CHANGELOG:

resource_aws_elastic_transcoder_pipeline: add plan time validations `content_config.storage_class`, `content_config_permissions.access`, `content_config_permissions.grantee`, `content_config_permissions.grantee_type`,
`notifications.completed`, `notifications.error`, `notifications.progressing`, `notifications.warning`,
`thumbnail_config.storage_class`, `thumbnail_config_permissions.access`, `thumbnail_config_permissions.grantee`, `thumbnail_config_permissions.grantee_type`.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSElasticTranscoderPipeline_'
--- PASS: TestAccAWSElasticTranscoderPipeline_basic (151.20s)
--- PASS: TestAccAWSElasticTranscoderPipeline_kmsKey (263.72s)
--- PASS: TestAccAWSElasticTranscoderPipeline_notifications (384.76s)
--- PASS: TestAccAWSElasticTranscoderPipeline_withContentConfig (278.10s)
--- PASS: TestAccAWSElasticTranscoderPipeline_withPermissions (137.67s)
--- PASS: TestAccAWSElasticTranscoderPipeline_disappears (175.47s)

@DrFaust92 DrFaust92 requested a review from a team June 27, 2020 20:51
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/elastic-transcoder tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 27, 2020
@DrFaust92 DrFaust92 force-pushed the r/elastictrascoder_refactor branch from d41838b to 182bee2 Compare August 24, 2020 14:58
Base automatically changed from master to main January 23, 2021 00:58
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:58
@DrFaust92 DrFaust92 force-pushed the r/elastictrascoder_refactor branch from 182bee2 to e2b3260 Compare February 11, 2021 21:11
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 11, 2021
@anGie44 anGie44 self-assigned this Feb 11, 2021
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple nitpicks here and comment re: the "grantee" validation. i'm not sure if we can readily validate all the possibilities, but we should definitely document them if not already done so 👍

.changelog/13973.txt Outdated Show resolved Hide resolved
aws/resource_aws_elastic_transcoder_pipeline.go Outdated Show resolved Hide resolved
aws/resource_aws_elastic_transcoder_pipeline.go Outdated Show resolved Hide resolved
aws/resource_aws_elastic_transcoder_pipeline_test.go Outdated Show resolved Hide resolved
aws/resource_aws_elastic_transcoder_pipeline_test.go Outdated Show resolved Hide resolved
aws/resource_aws_elastic_transcoder_pipeline_test.go Outdated Show resolved Hide resolved
aws/resource_aws_elastic_transcoder_pipeline_test.go Outdated Show resolved Hide resolved
aws/resource_aws_elastic_transcoder_pipeline_test.go Outdated Show resolved Hide resolved
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Feb 11, 2021
@DrFaust92
Copy link
Collaborator Author

Added docs and addressed comments

Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM 👍 thanks @DrFaust92

Output of acceptance tests (commercial):

--- PASS: TestAccAWSElasticTranscoderPipeline_disappears (19.42s)
--- PASS: TestAccAWSElasticTranscoderPipeline_kmsKey (21.90s)
--- PASS: TestAccAWSElasticTranscoderPipeline_withPermissions (23.32s)
--- PASS: TestAccAWSElasticTranscoderPipeline_notifications (35.24s)
--- PASS: TestAccAWSElasticTranscoderPipeline_withContentConfig (35.26s)
--- PASS: TestAccAWSElasticTranscoderPipeline_basic (39.11s)

@anGie44 anGie44 added this to the v3.28.0 milestone Feb 12, 2021
@anGie44 anGie44 merged commit c16b1c0 into hashicorp:main Feb 12, 2021
@ghost
Copy link

ghost commented Feb 12, 2021

This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 14, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 14, 2021
@DrFaust92 DrFaust92 deleted the r/elastictrascoder_refactor branch April 15, 2021 10:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants