Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "Removed" attributes #14001

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Remove "Removed" attributes #14001

merged 1 commit into from
Jul 13, 2020

Conversation

appilon
Copy link
Contributor

@appilon appilon commented Jun 30, 2020

This removes all removed attributes as that feature was cut in V2 of the SDK. The reason is foggy at the moment but I believed it resulted in hanging onto technical debt in the SDK codebase, when in effect Terraform will error without these markings. This PR may be blocked until V3 release of the provider? But technically I think this could be merged now, the user will simply see a more generic terraform core level error message (I would imagine, probably should confirm).

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #12087

Release note for CHANGELOG:

* All "removed" attributes are cut, using them would result in a Terraform Core level error.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@appilon appilon requested a review from a team June 30, 2020 19:56
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/apigateway Issues and PRs that pertain to the apigateway service. service/applicationautoscaling service/appmesh Issues and PRs that pertain to the appmesh service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/batch Issues and PRs that pertain to the batch service. service/cloudfront Issues and PRs that pertain to the cloudfront service. service/directconnect Issues and PRs that pertain to the directconnect service. service/ec2 Issues and PRs that pertain to the ec2 service. service/ecs Issues and PRs that pertain to the ecs service. service/efs Issues and PRs that pertain to the efs service. service/elasticache Issues and PRs that pertain to the elasticache service. service/iam Issues and PRs that pertain to the iam service. service/redshift Issues and PRs that pertain to the redshift service. service/route53 Issues and PRs that pertain to the route53 service. service/waf Issues and PRs that pertain to the waf service. labels Jun 30, 2020
@appilon appilon added this to the v3.0.0 milestone Jun 30, 2020
bflad
bflad approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I vote for making this one of the first merges when we cutover to major release work. 😜

@bflad bflad mentioned this pull request Jul 2, 2020
Closed
18 tasks
@appilon appilon force-pushed the td-remove-removed branch from e4ee41b to 3586a1a Compare July 6, 2020 22:32
@appilon appilon merged commit da2124c into master Jul 13, 2020
@appilon appilon deleted the td-remove-removed branch July 13, 2020 16:09
@ghost
Copy link

ghost commented Jul 31, 2020

This has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@bflad bflad mentioned this pull request Aug 5, 2020
Closed
@ghost
Copy link

ghost commented Aug 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
provider Pertains to the provider itself, rather than any interaction with AWS. service/apigateway Issues and PRs that pertain to the apigateway service. service/appmesh Issues and PRs that pertain to the appmesh service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/batch Issues and PRs that pertain to the batch service. service/cloudfront Issues and PRs that pertain to the cloudfront service. service/directconnect Issues and PRs that pertain to the directconnect service. service/ec2 Issues and PRs that pertain to the ec2 service. service/ecs Issues and PRs that pertain to the ecs service. service/efs Issues and PRs that pertain to the efs service. service/elasticache Issues and PRs that pertain to the elasticache service. service/iam Issues and PRs that pertain to the iam service. service/redshift Issues and PRs that pertain to the redshift service. service/route53 Issues and PRs that pertain to the route53 service. service/waf Issues and PRs that pertain to the waf service. size/XL Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@appilon @bflad