Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_workspaces_bundle: Fix empty (private) owner #14535

Merged
merged 4 commits into from
Nov 10, 2020
Merged

aws_workspaces_bundle: Fix empty (private) owner #14535

merged 4 commits into from
Nov 10, 2020

Conversation

Tensho
Copy link
Contributor

@Tensho Tensho commented Aug 10, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

aws_workspaces_bundle: Fix empty (private) owner

Closes #14206.

Acceptance Tests

For private bundles test I've implemented the kind of the same trick (AWS_WORKSPACES_BUNDLE_NAME) as in aws_workspaces_image test.

$ AWS_WORKSPACES_BUNDLE_NAME=PerformanceLinuxBaseline AWS_DEFAULT_REGION=us-east-1 make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsWorkspaceBundle'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsWorkspaceBundle -timeout 120m
=== RUN   TestAccDataSourceAwsWorkspaceBundle_basic
=== PAUSE TestAccDataSourceAwsWorkspaceBundle_basic
=== RUN   TestAccDataSourceAwsWorkspaceBundle_byOwnerName
=== PAUSE TestAccDataSourceAwsWorkspaceBundle_byOwnerName
=== RUN   TestAccDataSourceAwsWorkspaceBundle_bundleIDAndNameConflict
=== PAUSE TestAccDataSourceAwsWorkspaceBundle_bundleIDAndNameConflict
=== RUN   TestAccDataSourceAwsWorkspaceBundle_privateOwner
=== PAUSE TestAccDataSourceAwsWorkspaceBundle_privateOwner
=== CONT  TestAccDataSourceAwsWorkspaceBundle_basic
=== CONT  TestAccDataSourceAwsWorkspaceBundle_privateOwner
=== CONT  TestAccDataSourceAwsWorkspaceBundle_bundleIDAndNameConflict
=== CONT  TestAccDataSourceAwsWorkspaceBundle_byOwnerName
--- PASS: TestAccDataSourceAwsWorkspaceBundle_bundleIDAndNameConflict (2.23s)
--- PASS: TestAccDataSourceAwsWorkspaceBundle_basic (20.44s)
--- PASS: TestAccDataSourceAwsWorkspaceBundle_privateOwner (20.51s)
--- PASS: TestAccDataSourceAwsWorkspaceBundle_byOwnerName (25.91s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	28.444s

@Tensho Tensho requested a review from a team August 10, 2020 09:07
@ghost ghost added size/S Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/workspaces Issues and PRs that pertain to the workspaces service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 10, 2020
@Tensho Tensho force-pushed the workspaces-empty-bundle-owner branch from 080e5a7 to a2bf2fa Compare August 25, 2020 10:03
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. and removed size/S Managed by automation to categorize the size of a PR. labels Aug 25, 2020
@Tensho Tensho mentioned this pull request Sep 7, 2020
Merged
DrFaust92
DrFaust92 suggested changes Oct 12, 2020
View reviewed changes
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small change

aws/data_source_aws_workspaces_bundle_test.go Outdated
func testAccDataSourceAwsWorkspaceBundleConfig(bundleID string) string {
return fmt.Sprintf(`
data "aws_workspaces_bundle" "test" {
data aws_workspaces_bundle test {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets revert quotes.

@Tensho Tensho force-pushed the workspaces-empty-bundle-owner branch from a0895d9 to faa9bee Compare October 23, 2020 13:10
@ghost ghost added size/S Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Oct 23, 2020
@Tensho Tensho force-pushed the workspaces-empty-bundle-owner branch from 1d7b001 to 8417348 Compare November 9, 2020 10:51
@Tensho Tensho requested a review from a team as a code owner November 9, 2020 10:51
@Tensho Tensho force-pushed the workspaces-empty-bundle-owner branch from 8417348 to 9617777 Compare November 9, 2020 13:48
gdavison
gdavison approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccDataSourceAwsWorkspaceBundle_bundleIDAndNameConflict (33.06s)
--- PASS: TestAccDataSourceAwsWorkspaceBundle_privateOwner (73.64s)
--- PASS: TestAccDataSourceAwsWorkspaceBundle_basic (74.61s)
--- PASS: TestAccDataSourceAwsWorkspaceBundle_byOwnerName (76.38s)

@gdavison gdavison removed the needs-triage Waiting for first response or review from a maintainer. label Nov 10, 2020
@gdavison gdavison added this to the v3.15.0 milestone Nov 10, 2020
@breathingdust breathingdust merged commit 7d387a2 into hashicorp:master Nov 10, 2020
breathingdust added a commit that referenced this pull request Nov 10, 2020
@breathingdust
Update CHANGELOG.md for #14535
3d30951
@Tensho Tensho deleted the workspaces-empty-bundle-owner branch November 10, 2020 17:32
@ghost
Copy link

ghost commented Nov 12, 2020

This has been released in version 3.15.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Dec 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DrFaust92 DrFaust92 DrFaust92 requested changes

@gdavison gdavison gdavison approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/workspaces Issues and PRs that pertain to the workspaces service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.15.0
Development

Successfully merging this pull request may close these issues.

Bundle Owner errors when empty
4 participants
@Tensho @gdavison @DrFaust92 @breathingdust