Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_imagebuilder_image_recipe: Ensure proper ordering of component configuration blocks #16566

Merged
merged 1 commit into from
Dec 9, 2020
Merged

resource/aws_imagebuilder_image_recipe: Ensure proper ordering of component configuration blocks #16566

merged 1 commit into from
Dec 9, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Dec 3, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16533

Release note for CHANGELOG:

data-source/aws_imagebuilder_image_recipe: Ensure proper ordering of `component` attribute
resource/aws_imagebuilder_image_recipe: Ensure proper ordering of `component` configuration blocks

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAwsImageBuilderImageRecipe_basic (36.53s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_DeviceName (38.39s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_DeleteOnTermination (37.06s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Encrypted (38.32s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Iops (37.85s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_KmsKeyId (35.91s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_SnapshotId (47.80s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeSize (37.66s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeType (35.44s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_NoDevice (34.26s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_VirtualName (38.65s)
--- PASS: TestAccAwsImageBuilderImageRecipe_Component (44.83s)
--- PASS: TestAccAwsImageBuilderImageRecipe_Description (35.08s)
--- PASS: TestAccAwsImageBuilderImageRecipe_disappears (33.00s)
--- PASS: TestAccAwsImageBuilderImageRecipe_Tags (66.51s)

--- PASS: TestAccAwsImageBuilderImageRecipeDataSource_Arn (27.18s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAwsImageBuilderImageRecipe_basic (41.62s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_DeviceName (42.55s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_DeleteOnTermination (41.46s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Encrypted (40.31s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Iops (43.00s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_KmsKeyId (42.25s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_SnapshotId (49.99s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeSize (42.76s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeType (44.07s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_NoDevice (39.93s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_VirtualName (40.95s)
--- PASS: TestAccAwsImageBuilderImageRecipe_Component (43.14s)
--- PASS: TestAccAwsImageBuilderImageRecipe_Description (41.88s)
--- PASS: TestAccAwsImageBuilderImageRecipe_disappears (36.60s)
--- PASS: TestAccAwsImageBuilderImageRecipe_Tags (75.02s)

--- PASS: TestAccAwsImageBuilderImageRecipeDataSource_Arn (31.71s)

@bflad bflad added the bug Addresses a defect in current functionality. label Dec 3, 2020
@bflad bflad requested a review from a team as a code owner December 3, 2020 15:33
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 3, 2020
@bflad
resource/aws_imagebuilder_image_recipe: Ensure proper ordering of `co…
28c2e1e 
…mponent` configuration blocks

Reference: #16533

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccAwsImageBuilderImageRecipe_basic (36.53s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_DeviceName (38.39s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_DeleteOnTermination (37.06s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Encrypted (38.32s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Iops (37.85s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_KmsKeyId (35.91s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_SnapshotId (47.80s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeSize (37.66s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeType (35.44s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_NoDevice (34.26s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_VirtualName (38.65s)
--- PASS: TestAccAwsImageBuilderImageRecipe_Component (44.83s)
--- PASS: TestAccAwsImageBuilderImageRecipe_Description (35.08s)
--- PASS: TestAccAwsImageBuilderImageRecipe_disappears (33.00s)
--- PASS: TestAccAwsImageBuilderImageRecipe_Tags (66.51s)

--- PASS: TestAccAwsImageBuilderImageRecipeDataSource_Arn (27.18s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- PASS: TestAccAwsImageBuilderImageRecipe_basic (41.62s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_DeviceName (42.55s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_DeleteOnTermination (41.46s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Encrypted (40.31s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Iops (43.00s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_KmsKeyId (42.25s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_SnapshotId (49.99s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeSize (42.76s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeType (44.07s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_NoDevice (39.93s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_VirtualName (40.95s)
--- PASS: TestAccAwsImageBuilderImageRecipe_Component (43.14s)
--- PASS: TestAccAwsImageBuilderImageRecipe_Description (41.88s)
--- PASS: TestAccAwsImageBuilderImageRecipe_disappears (36.60s)
--- PASS: TestAccAwsImageBuilderImageRecipe_Tags (75.02s)

--- PASS: TestAccAwsImageBuilderImageRecipeDataSource_Arn (31.71s)
```
@bflad bflad force-pushed the b-aws_imagebuilder_image_recipe-component-ordering branch from 7741a9f to 28c2e1e Compare December 3, 2020 15:38
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Dec 3, 2020
@bflad bflad mentioned this pull request Dec 3, 2020
Closed
@anGie44 anGie44 self-requested a review December 9, 2020 19:01
anGie44
anGie44 approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

output of tests in commercial:

--- PASS: TestAccAwsImageBuilderImageRecipe_disappears (314.67s)
--- PASS: TestAccAwsImageBuilderImageRecipe_basic (317.94s)
--- PASS: TestAccAwsImageBuilderImageRecipe_Description (318.63s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeType (320.06s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_NoDevice (320.14s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_DeleteOnTermination (320.30s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeSize (321.30s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_DeviceName (321.56s)
--- PASS: TestAccAwsImageBuilderImageRecipe_Component (321.97s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Iops (322.44s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_KmsKeyId (323.73s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Encrypted (324.13s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_VirtualName (324.84s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_SnapshotId (334.72s)
--- PASS: TestAccAwsImageBuilderImageRecipe_Tags (352.70s)

output of tests in gov cloud:

--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeType (131.72s)
--- PASS: TestAccAwsImageBuilderImageRecipe_Description (145.66s)
--- PASS: TestAccAwsImageBuilderImageRecipe_disappears (154.31s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Encrypted (163.60s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_Iops (164.79s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_KmsKeyId (176.53s)
--- PASS: TestAccAwsImageBuilderImageRecipe_basic (177.68s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_DeviceName (177.82s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_VirtualName (177.92s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_VolumeSize (177.96s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_NoDevice (178.00s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_DeleteOnTermination (178.31s)
--- PASS: TestAccAwsImageBuilderImageRecipe_Component (178.85s)
--- PASS: TestAccAwsImageBuilderImageRecipe_BlockDeviceMapping_Ebs_SnapshotId (181.20s)
--- PASS: TestAccAwsImageBuilderImageRecipe_Tags (209.72s)

@bflad bflad added this to the v3.21.0 milestone Dec 9, 2020
@bflad bflad merged commit 3ecadf2 into master Dec 9, 2020
@bflad bflad deleted the b-aws_imagebuilder_image_recipe-component-ordering branch December 9, 2020 20:33
bflad added a commit that referenced this pull request Dec 9, 2020
@bflad
Update CHANGELOG for #16566
88c71fb
@ghost
Copy link

ghost commented Dec 11, 2020

This has been released in version 3.21.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jan 9, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.21.0
Development

Successfully merging this pull request may close these issues.

aws_imagebuilder_image_recipe creates components in random order
2 participants
@bflad @anGie44