Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Glue catalog table empty partition keys #16727

Merged
merged 2 commits into from
Jan 5, 2021
Merged

Glue catalog table empty partition keys #16727

merged 2 commits into from
Jan 5, 2021

Conversation

gmazelier
Copy link
Contributor

@gmazelier gmazelier commented Dec 11, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #5206

Release note for CHANGELOG:

Bug: Glue table partition keys should be set to empty list instead of being unset (#16727)

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSGlueCatalogTable_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueCatalogTable_ -timeout 120m
=== RUN   TestAccAWSGlueCatalogTable_basic
=== PAUSE TestAccAWSGlueCatalogTable_basic
=== RUN   TestAccAWSGlueCatalogTable_columnParameters
=== PAUSE TestAccAWSGlueCatalogTable_columnParameters
=== RUN   TestAccAWSGlueCatalogTable_full
=== PAUSE TestAccAWSGlueCatalogTable_full
=== RUN   TestAccAWSGlueCatalogTable_update_addValues
=== PAUSE TestAccAWSGlueCatalogTable_update_addValues
=== RUN   TestAccAWSGlueCatalogTable_update_replaceValues
=== PAUSE TestAccAWSGlueCatalogTable_update_replaceValues
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock
=== RUN   TestAccAWSGlueCatalogTable_partitionIndexesSingle
=== PAUSE TestAccAWSGlueCatalogTable_partitionIndexesSingle
=== RUN   TestAccAWSGlueCatalogTable_partitionIndexesMultiple
=== PAUSE TestAccAWSGlueCatalogTable_partitionIndexesMultiple
=== RUN   TestAccAWSGlueCatalogTable_disappears
=== PAUSE TestAccAWSGlueCatalogTable_disappears
=== CONT  TestAccAWSGlueCatalogTable_basic
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues
=== CONT  TestAccAWSGlueCatalogTable_update_replaceValues
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock
=== CONT  TestAccAWSGlueCatalogTable_full
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock
=== CONT  TestAccAWSGlueCatalogTable_partitionIndexesMultiple
=== CONT  TestAccAWSGlueCatalogTable_update_addValues
=== CONT  TestAccAWSGlueCatalogTable_disappears
=== CONT  TestAccAWSGlueCatalogTable_partitionIndexesSingle
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock
=== CONT  TestAccAWSGlueCatalogTable_columnParameters
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock (60.13s)
--- PASS: TestAccAWSGlueCatalogTable_disappears (60.39s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock (60.48s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock (61.93s)
--- PASS: TestAccAWSGlueCatalogTable_columnParameters (66.22s)
--- PASS: TestAccAWSGlueCatalogTable_partitionIndexesMultiple (66.87s)
--- PASS: TestAccAWSGlueCatalogTable_full (69.13s)
--- PASS: TestAccAWSGlueCatalogTable_basic (71.02s)
--- PASS: TestAccAWSGlueCatalogTable_partitionIndexesSingle (71.26s)
--- PASS: TestAccAWSGlueCatalogTable_update_replaceValues (100.75s)
--- PASS: TestAccAWSGlueCatalogTable_update_addValues (100.77s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues (100.89s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	102.539s

@gmazelier gmazelier requested a review from a team as a code owner December 11, 2020 21:17
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 11, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 11, 2020
@gmazelier gmazelier marked this pull request as draft December 11, 2020 21:19
@DrFaust92 DrFaust92 added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 11, 2020
@gmazelier gmazelier changed the title [WIP] Glue catalog table empty partition keys Glue catalog table empty partition keys Dec 11, 2020
@gmazelier gmazelier marked this pull request as ready for review December 11, 2020 22:12
@DrFaust92 DrFaust92 self-assigned this Dec 11, 2020
DrFaust92
DrFaust92 approved these changes Dec 11, 2020
View reviewed changes
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

--- PASS: TestAccAWSGlueCatalogTable_disappears (39.24s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock (41.77s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock (42.02s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock (44.07s)
--- PASS: TestAccAWSGlueCatalogTable_columnParameters (51.85s)
--- PASS: TestAccAWSGlueCatalogTable_partitionIndexesMultiple (52.26s)
--- PASS: TestAccAWSGlueCatalogTable_partitionIndexesSingle (52.94s)
--- PASS: TestAccAWSGlueCatalogTable_full (52.96s)
--- PASS: TestAccAWSGlueCatalogTable_basic (54.23s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues (81.03s)
--- PASS: TestAccAWSGlueCatalogTable_update_addValues (81.35s)
--- PASS: TestAccAWSGlueCatalogTable_update_replaceValues (85.88s)

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @gmazelier!

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TESTARGS='-run=TestAccAWSGlueCatalogTable_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueCatalogTable_ -timeout 120m
=== RUN   TestAccAWSGlueCatalogTable_basic
=== PAUSE TestAccAWSGlueCatalogTable_basic
=== RUN   TestAccAWSGlueCatalogTable_columnParameters
=== PAUSE TestAccAWSGlueCatalogTable_columnParameters
=== RUN   TestAccAWSGlueCatalogTable_full
=== PAUSE TestAccAWSGlueCatalogTable_full
=== RUN   TestAccAWSGlueCatalogTable_update_addValues
=== PAUSE TestAccAWSGlueCatalogTable_update_addValues
=== RUN   TestAccAWSGlueCatalogTable_update_replaceValues
=== PAUSE TestAccAWSGlueCatalogTable_update_replaceValues
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock
=== RUN   TestAccAWSGlueCatalogTable_partitionIndexesSingle
=== PAUSE TestAccAWSGlueCatalogTable_partitionIndexesSingle
=== RUN   TestAccAWSGlueCatalogTable_partitionIndexesMultiple
=== PAUSE TestAccAWSGlueCatalogTable_partitionIndexesMultiple
=== RUN   TestAccAWSGlueCatalogTable_disappears
=== PAUSE TestAccAWSGlueCatalogTable_disappears
=== CONT  TestAccAWSGlueCatalogTable_basic
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues
=== CONT  TestAccAWSGlueCatalogTable_disappears
=== CONT  TestAccAWSGlueCatalogTable_partitionIndexesMultiple
=== CONT  TestAccAWSGlueCatalogTable_partitionIndexesSingle
=== CONT  TestAccAWSGlueCatalogTable_update_replaceValues
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock
=== CONT  TestAccAWSGlueCatalogTable_columnParameters
=== CONT  TestAccAWSGlueCatalogTable_update_addValues
=== CONT  TestAccAWSGlueCatalogTable_full
2021/01/05 10:44:54 [DEBUG] Trying to get account information via sts:GetCallerIdentity
--- PASS: TestAccAWSGlueCatalogTable_disappears (15.66s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock (17.25s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock (17.27s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock (17.44s)
--- PASS: TestAccAWSGlueCatalogTable_basic (17.74s)
--- PASS: TestAccAWSGlueCatalogTable_full (19.22s)
--- PASS: TestAccAWSGlueCatalogTable_columnParameters (19.29s)
--- PASS: TestAccAWSGlueCatalogTable_partitionIndexesMultiple (19.29s)
--- PASS: TestAccAWSGlueCatalogTable_partitionIndexesSingle (19.95s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues (28.59s)
--- PASS: TestAccAWSGlueCatalogTable_update_replaceValues (29.85s)
--- PASS: TestAccAWSGlueCatalogTable_update_addValues (30.56s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	32.219s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TESTARGS='-run=TestAccAWSGlueCatalogTable_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueCatalogTable_ -timeout 120m
=== RUN   TestAccAWSGlueCatalogTable_basic
=== PAUSE TestAccAWSGlueCatalogTable_basic
=== RUN   TestAccAWSGlueCatalogTable_columnParameters
=== PAUSE TestAccAWSGlueCatalogTable_columnParameters
=== RUN   TestAccAWSGlueCatalogTable_full
=== PAUSE TestAccAWSGlueCatalogTable_full
=== RUN   TestAccAWSGlueCatalogTable_update_addValues
=== PAUSE TestAccAWSGlueCatalogTable_update_addValues
=== RUN   TestAccAWSGlueCatalogTable_update_replaceValues
=== PAUSE TestAccAWSGlueCatalogTable_update_replaceValues
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock
=== RUN   TestAccAWSGlueCatalogTable_partitionIndexesSingle
=== PAUSE TestAccAWSGlueCatalogTable_partitionIndexesSingle
=== RUN   TestAccAWSGlueCatalogTable_partitionIndexesMultiple
=== PAUSE TestAccAWSGlueCatalogTable_partitionIndexesMultiple
=== RUN   TestAccAWSGlueCatalogTable_disappears
=== PAUSE TestAccAWSGlueCatalogTable_disappears
=== CONT  TestAccAWSGlueCatalogTable_basic
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues
=== CONT  TestAccAWSGlueCatalogTable_disappears
=== CONT  TestAccAWSGlueCatalogTable_partitionIndexesMultiple
=== CONT  TestAccAWSGlueCatalogTable_partitionIndexesSingle
=== CONT  TestAccAWSGlueCatalogTable_update_replaceValues
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock
=== CONT  TestAccAWSGlueCatalogTable_full
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock
=== CONT  TestAccAWSGlueCatalogTable_update_addValues
=== CONT  TestAccAWSGlueCatalogTable_columnParameters
2021/01/05 10:45:48 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/01/05 10:45:48 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/01/05 10:45:51 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/01/05 10:45:51 [DEBUG] Trying to get account information via sts:GetCallerIdentity
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock (12.02s)
--- PASS: TestAccAWSGlueCatalogTable_disappears (12.73s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock (13.94s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock (14.04s)
2021/01/05 10:45:55 [INFO] AWS Auth provider used: "SharedCredentialsProvider"
--- PASS: TestAccAWSGlueCatalogTable_columnParameters (15.36s)
--- PASS: TestAccAWSGlueCatalogTable_full (15.51s)
--- PASS: TestAccAWSGlueCatalogTable_partitionIndexesSingle (15.79s)
--- PASS: TestAccAWSGlueCatalogTable_basic (16.00s)
--- PASS: TestAccAWSGlueCatalogTable_partitionIndexesMultiple (16.36s)
--- PASS: TestAccAWSGlueCatalogTable_update_replaceValues (21.93s)
--- PASS: TestAccAWSGlueCatalogTable_update_addValues (22.90s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues (23.77s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	25.407s

@breathingdust breathingdust merged commit 94ab63a into hashicorp:master Jan 5, 2021
@github-actions github-actions bot added this to the v3.23.0 milestone Jan 5, 2021
breathingdust added a commit that referenced this pull request Jan 5, 2021
@breathingdust
Update CHANGELOG.md for #16727
d2fba84
@ghost
Copy link

ghost commented Jan 8, 2021

This has been released in version 3.23.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Feb 5, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 5, 2021
@DrFaust92 DrFaust92 removed their assignment Jun 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DrFaust92 DrFaust92 DrFaust92 approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/glue Issues and PRs that pertain to the glue service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.23.0
Development

Successfully merging this pull request may close these issues.

Glue table partition keys should be set to empty list instead of being unset
3 participants
@gmazelier @breathingdust @DrFaust92