Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle ObjectNotFoundException gracefully when deleting app autoscaling target #18115

Conversation

sworisbreathing
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #18114

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

N/A. The existing test cases don't cover such a scenario and I'm not sure how to set the test up myself. I copied the fix for aws_appautoscaling_policy which itself doesn't appear to cover this scenario.

@sworisbreathing sworisbreathing requested a review from a team as a code owner March 16, 2021 03:38
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/applicationautoscaling labels Mar 16, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 16, 2021
@anGie44 anGie44 removed the needs-triage Waiting for first response or review from a maintainer. label Apr 23, 2021
@anGie44 anGie44 self-assigned this Apr 23, 2021
@anGie44 anGie44 added the bug Addresses a defect in current functionality. label Apr 23, 2021
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @sworisbreathing 🚀

Output of acceptance tests (commercial):

--- PASS: TestAccAWSAppautoScalingTarget_multipleTargets (25.54s)
--- PASS: TestAccAWSAppautoScalingTarget_optionalRoleArn (26.08s)
--- PASS: TestAccAWSAppautoScalingTarget_spotFleetRequest (76.77s)
--- PASS: TestAccAWSAppautoScalingTarget_disappears (86.35s)
--- PASS: TestAccAWSAppautoScalingTarget_basic (100.04s)
--- PASS: TestAccAWSAppautoScalingTarget_emrCluster (843.12s)

@anGie44 anGie44 added this to the v3.39.0 milestone May 5, 2021
@anGie44 anGie44 merged commit a1124c7 into hashicorp:main May 5, 2021
@ghost
Copy link

ghost commented May 7, 2021

This has been released in version 3.39.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

github-actions bot commented Jun 6, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ObjectNotFoundException when destroying appautoscaling target that does not exist
2 participants