Bugfix retry behavior in aws_ssoadmin_managed_policy_attachment for eventual consistency issue

[jvitor03]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19215

This PR adds a retry behavior for Create and destroy in the aws_ssoadmin_managed_policy_attachment-consitency resource.

Output from acceptance testing:

No acceptance testes where created, because they are not reliable to cover eventual consistency issues: https://github.com/hashicorp/terraform-provider-aws/blob/main/docs/contributing/retries-and-waiters.md#eventual-consistency

Full trace log from the fix being used during a destroy: https://gist.github.com/jvitor03/89cb2d10213cebefcd76e95046118968

Log retry summary:

-----------------------------------------------------: timestamp=2021-05-03T01:28:54.732-0300
2021-05-03T01:28:54.732-0300 [INFO]  plugin.terraform-provider-aws: 2021/05/03 01:28:54 [DEBUG] [aws-sdk-go] {"__type":"ConflictException","Message":"There is a conflicting operation in process."}: timestamp=2021-05-03T01:28:54.732-0300
2021-05-03T01:28:54.732-0300 [INFO]  plugin.terraform-provider-aws: 2021/05/03 01:28:54 [DEBUG] [aws-sdk-go] DEBUG: Validate Response SSO Admin/DetachManagedPolicyFromPermissionSet failed, attempt 0/25, error ConflictException: There is a conflicting operation in process.: timestamp=2021-05-03T01:28:54.732-0300
2021-05-03T01:28:54.732-0300 [INFO]  plugin.terraform-provider-aws: 2021/05/03 01:28:54 [TRACE] Waiting 500ms before next try: timestamp=2021-05-03T01:28:54.732-0300
2021-05-03T01:28:54.896-0300 [INFO]  plugin.terraform-provider-aws: 2021/05/03 01:28:54 [DEBUG] [aws-sdk-go] DEBUG: Response SSO Admin/DeleteAccountAssignment Details:
---[ RESPONSE ]--------------------------------------

[...]

{"InstanceArn":"arn:aws:sso:::instance/ssoins-7223f43a8b17208a","ManagedPolicyArn":"arn:aws:iam::aws:policy/CloudWatchReadOnlyAccess","PermissionSetArn":"arn:aws:sso:::permissionSet/ssoins-7223f43a8b17208a/ps-eb12a5e3a0d6a825"}
-----------------------------------------------------: timestamp=2021-05-03T01:28:55.935-0300
2021-05-03T01:28:56.638-0300 [INFO]  plugin.terraform-provider-aws: 2021/05/03 01:28:56 [DEBUG] [aws-sdk-go] DEBUG: Retrying Request SSO Admin/DetachManagedPolicyFromPermissionSet, attempt 1: timestamp=2021-05-03T01:28:56.638-0300
2021-05-03T01:28:56.638-0300 [INFO]  plugin.terraform-provider-aws: 2021/05/03 01:28:56 [DEBUG] [aws-sdk-go] DEBUG: Request SSO Admin/DetachManagedPolicyFromPermissionSet Details:
---[ REQUEST POST-SIGN ]-----------------------------

[github-actions]

Welcome @jvitor03 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[aabadia]

👍

[anGie44]

Hi @jvitor03 , thank you for this PR and following the contribution guidelines for retry handling! With these eventual consistency errors happening on both create and delete, without a precise timeout as it can depend per account/user, we can instead add a connection retry handler in config.go to automatically retry when hitting the error described e.g.

client.ssoadminconn.Handlers.Retry.PushBack(func(r *request.Request) {
    if r.Operation.Name == "AttachManagedPolicyToPermissionSet" || r.Operation.Name == "DetachManagedPolicyFromPermissionSet" {
        if tfawserr.ErrCodeEquals(r.Error, ssoadmin.ErrCodeConflictException) {
            r.Retryable = aws.Bool(true)
	}
    }
}

[jvitor03]

That looks way better to avoid duplicated code, I will do the change.
Thanks for the review!

[anGie44]

Looks great @jvitor03 🚀

Output of acceptance tests:

--- PASS: TestAccAWSSSOAdminManagedPolicyAttachment_disappears (32.90s)
--- PASS: TestAccAWSSSOAdminManagedPolicyAttachment_disappears_permissionSet (24.52s)
--- PASS: TestAccAWSSSOAdminManagedPolicyAttachment_basic (32.00s)
--- PASS: TestAccAWSSSOAdminManagedPolicyAttachment_forceNew (57.42s)
--- PASS: TestAccAWSSSOAdminManagedPolicyAttachment_multipleManagedPolicies (82.14s)

[ghost]

This has been released in version 3.39.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.