Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/ecs_task_definition - add support for ephemeral_storage #19694

Merged
merged 4 commits into from
Jun 8, 2021
Merged

r/ecs_task_definition - add support for ephemeral_storage #19694

merged 4 commits into from
Jun 8, 2021

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19263

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEcsTaskDefinition_'
--- PASS: TestAccAWSEcsTaskDefinition_inferenceAccelerator (46.57s)
--- PASS: TestAccAWSEcsTaskDefinition_arrays (47.72s)
--- PASS: TestAccAWSEcsTaskDefinition_withDockerVolume (48.44s)
--- PASS: TestAccAWSEcsTaskDefinition_withDockerVolumeMinimalConfig (49.30s)
--- PASS: TestAccAWSEcsTaskDefinition_withTaskScopedDockerVolume (49.50s)
--- PASS: TestAccAWSEcsTaskDefinition_withScratchVolume (51.57s)
--- PASS: TestAccAWSEcsTaskDefinition_constraint (51.63s)
--- PASS: TestAccAWSEcsTaskDefinition_withTaskRoleArn (54.37s)
--- PASS: TestAccAWSEcsTaskDefinition_withPidMode (55.97s)
--- PASS: TestAccAWSEcsTaskDefinition_withNetworkMode (57.77s)
--- PASS: TestAccAWSEcsTaskDefinition_withIPCMode (58.96s)
--- PASS: TestAccAWSEcsTaskDefinition_ExecutionRole (59.01s)
--- PASS: TestAccAWSEcsTaskDefinition_withTransitEncryptionEFSVolume (63.87s)
--- PASS: TestAccAWSEcsTaskDefinition_withEFSVolumeMinimal (65.66s)
--- PASS: TestAccAWSEcsTaskDefinition_withEFSVolume (66.31s)
--- PASS: TestAccAWSEcsTaskDefinition_withEFSAccessPoint (67.72s)
--- PASS: TestAccAWSEcsTaskDefinition_changeVolumesForcesNewResource (76.83s)
--- PASS: TestAccAWSEcsTaskDefinition_basic (78.45s)
--- PASS: TestAccAWSEcsTaskDefinition_Fargate_ephemeralStorage (32.64s)
--- PASS: TestAccAWSEcsTaskDefinition_ProxyConfiguration (43.40s)
--- PASS: TestAccAWSEcsTaskDefinition_disappears (47.69s)
--- PASS: TestAccAWSEcsTaskDefinition_Fargate (46.31s)
--- PASS: TestAccAWSEcsTaskDefinition_Tags (104.37s)
--- PASS: TestAccAWSEcsTaskDefinition_withEcsService (148.39s)

@DrFaust92 DrFaust92 requested a review from a team as a code owner June 7, 2021 12:25
@ghost ghost added size/M Managed by automation to categorize the size of a PR. labels Jun 7, 2021
@DrFaust92 DrFaust92 changed the title e/ecs_task_definition - add support for ephemeral_storage r/ecs_task_definition - add support for ephemeral_storage Jun 7, 2021
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/ecs Issues and PRs that pertain to the ecs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 7, 2021
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 7, 2021
ewbankkit
ewbankkit approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSEcsTaskDefinition_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEcsTaskDefinition_ -timeout 180m
=== RUN   TestAccAWSEcsTaskDefinition_basic
=== PAUSE TestAccAWSEcsTaskDefinition_basic
=== RUN   TestAccAWSEcsTaskDefinition_withScratchVolume
=== PAUSE TestAccAWSEcsTaskDefinition_withScratchVolume
=== RUN   TestAccAWSEcsTaskDefinition_withDockerVolume
=== PAUSE TestAccAWSEcsTaskDefinition_withDockerVolume
=== RUN   TestAccAWSEcsTaskDefinition_withDockerVolumeMinimalConfig
=== PAUSE TestAccAWSEcsTaskDefinition_withDockerVolumeMinimalConfig
=== RUN   TestAccAWSEcsTaskDefinition_withEFSVolumeMinimal
=== PAUSE TestAccAWSEcsTaskDefinition_withEFSVolumeMinimal
=== RUN   TestAccAWSEcsTaskDefinition_withEFSVolume
=== PAUSE TestAccAWSEcsTaskDefinition_withEFSVolume
=== RUN   TestAccAWSEcsTaskDefinition_withTransitEncryptionEFSVolume
=== PAUSE TestAccAWSEcsTaskDefinition_withTransitEncryptionEFSVolume
=== RUN   TestAccAWSEcsTaskDefinition_withEFSAccessPoint
=== PAUSE TestAccAWSEcsTaskDefinition_withEFSAccessPoint
=== RUN   TestAccAWSEcsTaskDefinition_withFsxWinFileSystem
=== PAUSE TestAccAWSEcsTaskDefinition_withFsxWinFileSystem
=== RUN   TestAccAWSEcsTaskDefinition_withTaskScopedDockerVolume
=== PAUSE TestAccAWSEcsTaskDefinition_withTaskScopedDockerVolume
=== RUN   TestAccAWSEcsTaskDefinition_withEcsService
=== PAUSE TestAccAWSEcsTaskDefinition_withEcsService
=== RUN   TestAccAWSEcsTaskDefinition_withTaskRoleArn
=== PAUSE TestAccAWSEcsTaskDefinition_withTaskRoleArn
=== RUN   TestAccAWSEcsTaskDefinition_withNetworkMode
=== PAUSE TestAccAWSEcsTaskDefinition_withNetworkMode
=== RUN   TestAccAWSEcsTaskDefinition_withIPCMode
=== PAUSE TestAccAWSEcsTaskDefinition_withIPCMode
=== RUN   TestAccAWSEcsTaskDefinition_withPidMode
=== PAUSE TestAccAWSEcsTaskDefinition_withPidMode
=== RUN   TestAccAWSEcsTaskDefinition_constraint
=== PAUSE TestAccAWSEcsTaskDefinition_constraint
=== RUN   TestAccAWSEcsTaskDefinition_changeVolumesForcesNewResource
=== PAUSE TestAccAWSEcsTaskDefinition_changeVolumesForcesNewResource
=== RUN   TestAccAWSEcsTaskDefinition_arrays
=== PAUSE TestAccAWSEcsTaskDefinition_arrays
=== RUN   TestAccAWSEcsTaskDefinition_Fargate
=== PAUSE TestAccAWSEcsTaskDefinition_Fargate
=== RUN   TestAccAWSEcsTaskDefinition_Fargate_ephemeralStorage
=== PAUSE TestAccAWSEcsTaskDefinition_Fargate_ephemeralStorage
=== RUN   TestAccAWSEcsTaskDefinition_ExecutionRole
=== PAUSE TestAccAWSEcsTaskDefinition_ExecutionRole
=== RUN   TestAccAWSEcsTaskDefinition_disappears
=== PAUSE TestAccAWSEcsTaskDefinition_disappears
=== RUN   TestAccAWSEcsTaskDefinition_Tags
=== PAUSE TestAccAWSEcsTaskDefinition_Tags
=== RUN   TestAccAWSEcsTaskDefinition_ProxyConfiguration
=== PAUSE TestAccAWSEcsTaskDefinition_ProxyConfiguration
=== RUN   TestAccAWSEcsTaskDefinition_inferenceAccelerator
=== PAUSE TestAccAWSEcsTaskDefinition_inferenceAccelerator
=== CONT  TestAccAWSEcsTaskDefinition_basic
=== CONT  TestAccAWSEcsTaskDefinition_withIPCMode
=== CONT  TestAccAWSEcsTaskDefinition_Fargate_ephemeralStorage
=== CONT  TestAccAWSEcsTaskDefinition_Fargate
=== CONT  TestAccAWSEcsTaskDefinition_ExecutionRole
=== CONT  TestAccAWSEcsTaskDefinition_withScratchVolume
=== CONT  TestAccAWSEcsTaskDefinition_withEcsService
=== CONT  TestAccAWSEcsTaskDefinition_constraint
=== CONT  TestAccAWSEcsTaskDefinition_withPidMode
=== CONT  TestAccAWSEcsTaskDefinition_withEFSAccessPoint
=== CONT  TestAccAWSEcsTaskDefinition_withNetworkMode
=== CONT  TestAccAWSEcsTaskDefinition_withTaskRoleArn
=== CONT  TestAccAWSEcsTaskDefinition_arrays
=== CONT  TestAccAWSEcsTaskDefinition_withDockerVolume
=== CONT  TestAccAWSEcsTaskDefinition_changeVolumesForcesNewResource
=== CONT  TestAccAWSEcsTaskDefinition_withEFSVolumeMinimal
=== CONT  TestAccAWSEcsTaskDefinition_withDockerVolumeMinimalConfig
=== CONT  TestAccAWSEcsTaskDefinition_withTransitEncryptionEFSVolume
=== CONT  TestAccAWSEcsTaskDefinition_withEFSVolume
=== CONT  TestAccAWSEcsTaskDefinition_withFsxWinFileSystem
--- PASS: TestAccAWSEcsTaskDefinition_withScratchVolume (28.95s)
=== CONT  TestAccAWSEcsTaskDefinition_ProxyConfiguration
--- PASS: TestAccAWSEcsTaskDefinition_withDockerVolumeMinimalConfig (29.69s)
=== CONT  TestAccAWSEcsTaskDefinition_inferenceAccelerator
--- PASS: TestAccAWSEcsTaskDefinition_Fargate_ephemeralStorage (33.11s)
=== CONT  TestAccAWSEcsTaskDefinition_Tags
--- PASS: TestAccAWSEcsTaskDefinition_withDockerVolume (33.33s)
=== CONT  TestAccAWSEcsTaskDefinition_disappears
--- PASS: TestAccAWSEcsTaskDefinition_constraint (33.49s)
=== CONT  TestAccAWSEcsTaskDefinition_withTaskScopedDockerVolume
--- PASS: TestAccAWSEcsTaskDefinition_arrays (34.02s)
--- PASS: TestAccAWSEcsTaskDefinition_ExecutionRole (34.12s)
--- PASS: TestAccAWSEcsTaskDefinition_withIPCMode (34.42s)
--- PASS: TestAccAWSEcsTaskDefinition_withPidMode (34.74s)
--- PASS: TestAccAWSEcsTaskDefinition_withNetworkMode (36.98s)
--- PASS: TestAccAWSEcsTaskDefinition_withTaskRoleArn (37.82s)
--- PASS: TestAccAWSEcsTaskDefinition_Fargate (42.89s)
--- PASS: TestAccAWSEcsTaskDefinition_withTransitEncryptionEFSVolume (45.00s)
--- PASS: TestAccAWSEcsTaskDefinition_withEFSVolumeMinimal (45.22s)
--- PASS: TestAccAWSEcsTaskDefinition_withEFSVolume (45.31s)
--- PASS: TestAccAWSEcsTaskDefinition_withEFSAccessPoint (48.51s)
--- PASS: TestAccAWSEcsTaskDefinition_basic (50.40s)
--- PASS: TestAccAWSEcsTaskDefinition_changeVolumesForcesNewResource (50.62s)
--- PASS: TestAccAWSEcsTaskDefinition_inferenceAccelerator (22.92s)
--- PASS: TestAccAWSEcsTaskDefinition_withTaskScopedDockerVolume (20.78s)
--- PASS: TestAccAWSEcsTaskDefinition_ProxyConfiguration (30.19s)
--- PASS: TestAccAWSEcsTaskDefinition_disappears (26.65s)
--- PASS: TestAccAWSEcsTaskDefinition_Tags (42.78s)
--- PASS: TestAccAWSEcsTaskDefinition_withEcsService (122.70s)
--- PASS: TestAccAWSEcsTaskDefinition_withFsxWinFileSystem (3407.31s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	3410.627s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSEcsTaskDefinition_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEcsTaskDefinition_ -timeout 180m
=== RUN   TestAccAWSEcsTaskDefinition_basic
=== PAUSE TestAccAWSEcsTaskDefinition_basic
=== RUN   TestAccAWSEcsTaskDefinition_withScratchVolume
=== PAUSE TestAccAWSEcsTaskDefinition_withScratchVolume
=== RUN   TestAccAWSEcsTaskDefinition_withDockerVolume
=== PAUSE TestAccAWSEcsTaskDefinition_withDockerVolume
=== RUN   TestAccAWSEcsTaskDefinition_withDockerVolumeMinimalConfig
=== PAUSE TestAccAWSEcsTaskDefinition_withDockerVolumeMinimalConfig
=== RUN   TestAccAWSEcsTaskDefinition_withEFSVolumeMinimal
=== PAUSE TestAccAWSEcsTaskDefinition_withEFSVolumeMinimal
=== RUN   TestAccAWSEcsTaskDefinition_withEFSVolume
=== PAUSE TestAccAWSEcsTaskDefinition_withEFSVolume
=== RUN   TestAccAWSEcsTaskDefinition_withTransitEncryptionEFSVolume
=== PAUSE TestAccAWSEcsTaskDefinition_withTransitEncryptionEFSVolume
=== RUN   TestAccAWSEcsTaskDefinition_withEFSAccessPoint
=== PAUSE TestAccAWSEcsTaskDefinition_withEFSAccessPoint
=== RUN   TestAccAWSEcsTaskDefinition_withFsxWinFileSystem
    resource_aws_ecs_task_definition_test.go:369: Amazon FSx for Windows File Server volumes for ECS tasks are not supported in GovCloud partition
--- SKIP: TestAccAWSEcsTaskDefinition_withFsxWinFileSystem (0.00s)
=== RUN   TestAccAWSEcsTaskDefinition_withTaskScopedDockerVolume
=== PAUSE TestAccAWSEcsTaskDefinition_withTaskScopedDockerVolume
=== RUN   TestAccAWSEcsTaskDefinition_withEcsService
=== PAUSE TestAccAWSEcsTaskDefinition_withEcsService
=== RUN   TestAccAWSEcsTaskDefinition_withTaskRoleArn
=== PAUSE TestAccAWSEcsTaskDefinition_withTaskRoleArn
=== RUN   TestAccAWSEcsTaskDefinition_withNetworkMode
=== PAUSE TestAccAWSEcsTaskDefinition_withNetworkMode
=== RUN   TestAccAWSEcsTaskDefinition_withIPCMode
=== PAUSE TestAccAWSEcsTaskDefinition_withIPCMode
=== RUN   TestAccAWSEcsTaskDefinition_withPidMode
=== PAUSE TestAccAWSEcsTaskDefinition_withPidMode
=== RUN   TestAccAWSEcsTaskDefinition_constraint
=== PAUSE TestAccAWSEcsTaskDefinition_constraint
=== RUN   TestAccAWSEcsTaskDefinition_changeVolumesForcesNewResource
=== PAUSE TestAccAWSEcsTaskDefinition_changeVolumesForcesNewResource
=== RUN   TestAccAWSEcsTaskDefinition_arrays
=== PAUSE TestAccAWSEcsTaskDefinition_arrays
=== RUN   TestAccAWSEcsTaskDefinition_Fargate
=== PAUSE TestAccAWSEcsTaskDefinition_Fargate
=== RUN   TestAccAWSEcsTaskDefinition_Fargate_ephemeralStorage
=== PAUSE TestAccAWSEcsTaskDefinition_Fargate_ephemeralStorage
=== RUN   TestAccAWSEcsTaskDefinition_ExecutionRole
=== PAUSE TestAccAWSEcsTaskDefinition_ExecutionRole
=== RUN   TestAccAWSEcsTaskDefinition_disappears
=== PAUSE TestAccAWSEcsTaskDefinition_disappears
=== RUN   TestAccAWSEcsTaskDefinition_Tags
=== PAUSE TestAccAWSEcsTaskDefinition_Tags
=== RUN   TestAccAWSEcsTaskDefinition_ProxyConfiguration
=== PAUSE TestAccAWSEcsTaskDefinition_ProxyConfiguration
=== RUN   TestAccAWSEcsTaskDefinition_inferenceAccelerator
=== PAUSE TestAccAWSEcsTaskDefinition_inferenceAccelerator
=== CONT  TestAccAWSEcsTaskDefinition_basic
=== CONT  TestAccAWSEcsTaskDefinition_withPidMode
=== CONT  TestAccAWSEcsTaskDefinition_inferenceAccelerator
=== CONT  TestAccAWSEcsTaskDefinition_ProxyConfiguration
=== CONT  TestAccAWSEcsTaskDefinition_Tags
=== CONT  TestAccAWSEcsTaskDefinition_disappears
=== CONT  TestAccAWSEcsTaskDefinition_ExecutionRole
=== CONT  TestAccAWSEcsTaskDefinition_Fargate_ephemeralStorage
=== CONT  TestAccAWSEcsTaskDefinition_Fargate
=== CONT  TestAccAWSEcsTaskDefinition_constraint
=== CONT  TestAccAWSEcsTaskDefinition_withTaskRoleArn
=== CONT  TestAccAWSEcsTaskDefinition_arrays
=== CONT  TestAccAWSEcsTaskDefinition_withNetworkMode
=== CONT  TestAccAWSEcsTaskDefinition_withEFSAccessPoint
=== CONT  TestAccAWSEcsTaskDefinition_withTransitEncryptionEFSVolume
=== CONT  TestAccAWSEcsTaskDefinition_withEFSVolume
=== CONT  TestAccAWSEcsTaskDefinition_changeVolumesForcesNewResource
=== CONT  TestAccAWSEcsTaskDefinition_withIPCMode
=== CONT  TestAccAWSEcsTaskDefinition_withEFSVolumeMinimal
=== CONT  TestAccAWSEcsTaskDefinition_withTaskScopedDockerVolume
=== CONT  TestAccAWSEcsTaskDefinition_inferenceAccelerator
    provider_test.go:1103: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        2021/06/08 10:18:30 [DEBUG] Using modified User-Agent: Terraform/0.12.31 HashiCorp-terraform-exec/0.13.3
        
        Error: ClientException: Unsupported field 'inferenceAccelerators'.
        
          on terraform_plugin_test.tf line 2, in resource "aws_ecs_task_definition" "test":
           2: resource "aws_ecs_task_definition" "test" {
        
        
--- SKIP: TestAccAWSEcsTaskDefinition_inferenceAccelerator (11.74s)
=== CONT  TestAccAWSEcsTaskDefinition_withEcsService
--- PASS: TestAccAWSEcsTaskDefinition_arrays (30.10s)
=== CONT  TestAccAWSEcsTaskDefinition_withDockerVolume
--- PASS: TestAccAWSEcsTaskDefinition_withTaskScopedDockerVolume (33.41s)
=== CONT  TestAccAWSEcsTaskDefinition_withDockerVolumeMinimalConfig
--- PASS: TestAccAWSEcsTaskDefinition_constraint (33.87s)
=== CONT  TestAccAWSEcsTaskDefinition_withScratchVolume
--- PASS: TestAccAWSEcsTaskDefinition_Fargate_ephemeralStorage (33.91s)
--- PASS: TestAccAWSEcsTaskDefinition_withIPCMode (40.37s)
--- PASS: TestAccAWSEcsTaskDefinition_withPidMode (40.61s)
--- PASS: TestAccAWSEcsTaskDefinition_withNetworkMode (40.84s)
--- PASS: TestAccAWSEcsTaskDefinition_withTaskRoleArn (41.31s)
--- PASS: TestAccAWSEcsTaskDefinition_ExecutionRole (41.97s)
--- PASS: TestAccAWSEcsTaskDefinition_Fargate (43.89s)
--- PASS: TestAccAWSEcsTaskDefinition_ProxyConfiguration (45.02s)
--- PASS: TestAccAWSEcsTaskDefinition_withEFSVolumeMinimal (45.83s)
--- PASS: TestAccAWSEcsTaskDefinition_withTransitEncryptionEFSVolume (45.87s)
--- PASS: TestAccAWSEcsTaskDefinition_withEFSVolume (46.08s)
--- PASS: TestAccAWSEcsTaskDefinition_disappears (47.27s)
--- PASS: TestAccAWSEcsTaskDefinition_withEFSAccessPoint (48.35s)
--- PASS: TestAccAWSEcsTaskDefinition_changeVolumesForcesNewResource (50.29s)
--- PASS: TestAccAWSEcsTaskDefinition_basic (51.83s)
--- PASS: TestAccAWSEcsTaskDefinition_withDockerVolume (21.91s)
--- PASS: TestAccAWSEcsTaskDefinition_withScratchVolume (22.29s)
--- PASS: TestAccAWSEcsTaskDefinition_withDockerVolumeMinimalConfig (22.80s)
--- PASS: TestAccAWSEcsTaskDefinition_Tags (70.06s)
--- PASS: TestAccAWSEcsTaskDefinition_withEcsService (101.06s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	115.874s

@ewbankkit ewbankkit merged commit 12d5302 into hashicorp:main Jun 8, 2021
@github-actions github-actions bot added this to the v3.45.0 milestone Jun 8, 2021
@DrFaust92 DrFaust92 deleted the r/ecs_ephemral_storage branch June 8, 2021 15:57
@haarchri haarchri mentioned this pull request Jun 9, 2021
Closed
@github-actions
Copy link

This functionality has been released in v3.45.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ecs Issues and PRs that pertain to the ecs service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.45.0
Development

Successfully merging this pull request may close these issues.

Support for ephemeralStorage in Fargate ECS task definitions
2 participants
@DrFaust92 @ewbankkit