-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/route53_query_log - add arn
attribute + remove resource from state when doesn't exist
#20666
r/route53_query_log - add arn
attribute + remove resource from state when doesn't exist
#20666
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Commercial
% make testacc TESTARGS='-run=TestAccAWSRoute53QueryLog_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRoute53QueryLog_ -timeout 180m
go: downloading github.com/aws/aws-sdk-go v1.40.27
=== RUN TestAccAWSRoute53QueryLog_basic
=== PAUSE TestAccAWSRoute53QueryLog_basic
=== RUN TestAccAWSRoute53QueryLog_disappears
=== PAUSE TestAccAWSRoute53QueryLog_disappears
=== RUN TestAccAWSRoute53QueryLog_disappears_hostedZone
=== PAUSE TestAccAWSRoute53QueryLog_disappears_hostedZone
=== CONT TestAccAWSRoute53QueryLog_basic
=== CONT TestAccAWSRoute53QueryLog_disappears_hostedZone
=== CONT TestAccAWSRoute53QueryLog_disappears
--- PASS: TestAccAWSRoute53QueryLog_disappears_hostedZone (54.82s)
--- PASS: TestAccAWSRoute53QueryLog_basic (61.39s)
--- PASS: TestAccAWSRoute53QueryLog_disappears (66.37s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 69.798s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSRoute53QueryLog_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRoute53QueryLog_ -timeout 180m
=== RUN TestAccAWSRoute53QueryLog_basic
=== PAUSE TestAccAWSRoute53QueryLog_basic
=== RUN TestAccAWSRoute53QueryLog_disappears
=== PAUSE TestAccAWSRoute53QueryLog_disappears
=== RUN TestAccAWSRoute53QueryLog_disappears_hostedZone
=== PAUSE TestAccAWSRoute53QueryLog_disappears_hostedZone
=== CONT TestAccAWSRoute53QueryLog_basic
=== CONT TestAccAWSRoute53QueryLog_disappears_hostedZone
=== CONT TestAccAWSRoute53QueryLog_disappears
route53_query_log_test.go:40: Route 53 Query Log not available in this AWS Partition
=== CONT TestAccAWSRoute53QueryLog_basic
route53_query_log_test.go:40: Route 53 Query Log not available in this AWS Partition
--- SKIP: TestAccAWSRoute53QueryLog_disappears (1.33s)
=== CONT TestAccAWSRoute53QueryLog_disappears_hostedZone
route53_query_log_test.go:40: Route 53 Query Log not available in this AWS Partition
--- SKIP: TestAccAWSRoute53QueryLog_basic (1.33s)
--- SKIP: TestAccAWSRoute53QueryLog_disappears_hostedZone (1.33s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 4.575s
@DrFaust92 Thanks for the contribution 🎉 👏. |
This functionality has been released in v3.56.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #17954.
Output from acceptance testing: