Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recovery control health check type #20731

Merged

Conversation

ankita10051991
Copy link

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20730

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSRoute53HealthCheck_withRoutingControlArn'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRoute53HealthCheck_withRoutingControlArn -timeout 180m
=== RUN   TestAccAWSRoute53HealthCheck_withRoutingControlArn
=== PAUSE TestAccAWSRoute53HealthCheck_withRoutingControlArn
=== CONT  TestAccAWSRoute53HealthCheck_withRoutingControlArn
--- PASS: TestAccAWSRoute53HealthCheck_withRoutingControlArn (94.69s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	104.767s

...

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/route53 Issues and PRs that pertain to the route53 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 30, 2021
@anGie44 anGie44 removed the needs-triage Waiting for first response or review from a maintainer. label Aug 31, 2021
@anGie44 anGie44 self-assigned this Aug 31, 2021
.changelog/20731.txt Outdated Show resolved Hide resolved
@AdamTylerLynch
Copy link
Collaborator

@anGie44 we are seeing the linter flag on the docs, even though the value is valid. Any ideas here?

ERROR: File "./website/docs/r/route53_health_check.html.markdown", block #5 (lines 84-98):
1 issue(s) found:

Error: "RECOVERY_CONTROL" is an invalid value as type (aws_route53_health_check_invalid_type)

  on /var/folders/h8/p5dkjq2d7gv9wky4m1bz80_h12rnp_/T/tmp.LGBhK74i/main.tf line 11:
  11:   type                = "RECOVERY_CONTROL"

https://github.com/hashicorp/terraform-provider-aws/runs/3475661838?check_suite_focus=true#step:8:62

Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 thanks again @ankita10051991

Output of acceptance test:

--- PASS: TestAccAWSRoute53HealthCheck_withRoutingControlArn (66.16s)

@anGie44 anGie44 added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 31, 2021
@anGie44 anGie44 added this to the v3.57.0 milestone Aug 31, 2021
@anGie44
Copy link
Contributor

anGie44 commented Aug 31, 2021

Noting CI failure has been addressed with: #20741

@anGie44 anGie44 merged commit 2543ac3 into hashicorp:main Aug 31, 2021
@github-actions
Copy link

github-actions bot commented Sep 2, 2021

This functionality has been released in v3.57.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. partner Contribution from a partner. service/route53 Issues and PRs that pertain to the route53 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for route53 recovery controller health check
4 participants