-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update aws_dms_endpoint ressource to support new engines #21174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @dsarrio 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccAwsDmsEndpoint_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsDmsEndpoint_ -timeout 180m
=== RUN TestAccAwsDmsEndpoint_basic
=== PAUSE TestAccAwsDmsEndpoint_basic
=== RUN TestAccAwsDmsEndpoint_S3
=== PAUSE TestAccAwsDmsEndpoint_S3
=== RUN TestAccAwsDmsEndpoint_S3_ExtraConnectionAttributes
=== PAUSE TestAccAwsDmsEndpoint_S3_ExtraConnectionAttributes
=== RUN TestAccAwsDmsEndpoint_DynamoDb
=== PAUSE TestAccAwsDmsEndpoint_DynamoDb
=== RUN TestAccAwsDmsEndpoint_Elasticsearch
=== PAUSE TestAccAwsDmsEndpoint_Elasticsearch
=== RUN TestAccAwsDmsEndpoint_Elasticsearch_ExtraConnectionAttributes
=== PAUSE TestAccAwsDmsEndpoint_Elasticsearch_ExtraConnectionAttributes
=== RUN TestAccAwsDmsEndpoint_Elasticsearch_ErrorRetryDuration
=== PAUSE TestAccAwsDmsEndpoint_Elasticsearch_ErrorRetryDuration
=== RUN TestAccAwsDmsEndpoint_Elasticsearch_FullLoadErrorPercentage
=== PAUSE TestAccAwsDmsEndpoint_Elasticsearch_FullLoadErrorPercentage
=== RUN TestAccAwsDmsEndpoint_Kafka_Broker
=== PAUSE TestAccAwsDmsEndpoint_Kafka_Broker
=== RUN TestAccAwsDmsEndpoint_Kafka_Topic
=== PAUSE TestAccAwsDmsEndpoint_Kafka_Topic
=== RUN TestAccAwsDmsEndpoint_Kinesis
=== PAUSE TestAccAwsDmsEndpoint_Kinesis
=== RUN TestAccAwsDmsEndpoint_MongoDb
=== PAUSE TestAccAwsDmsEndpoint_MongoDb
=== RUN TestAccAwsDmsEndpoint_MongoDb_Update
=== PAUSE TestAccAwsDmsEndpoint_MongoDb_Update
=== RUN TestAccAwsDmsEndpoint_DocDB
=== PAUSE TestAccAwsDmsEndpoint_DocDB
=== RUN TestAccAwsDmsEndpoint_Db2
=== PAUSE TestAccAwsDmsEndpoint_Db2
=== CONT TestAccAwsDmsEndpoint_basic
=== CONT TestAccAwsDmsEndpoint_Kafka_Broker
=== CONT TestAccAwsDmsEndpoint_MongoDb
=== CONT TestAccAwsDmsEndpoint_MongoDb_Update
=== CONT TestAccAwsDmsEndpoint_DocDB
=== CONT TestAccAwsDmsEndpoint_S3_ExtraConnectionAttributes
=== CONT TestAccAwsDmsEndpoint_Db2
=== CONT TestAccAwsDmsEndpoint_Kinesis
=== CONT TestAccAwsDmsEndpoint_Elasticsearch
=== CONT TestAccAwsDmsEndpoint_Elasticsearch_ExtraConnectionAttributes
=== CONT TestAccAwsDmsEndpoint_Elasticsearch_ErrorRetryDuration
=== CONT TestAccAwsDmsEndpoint_DynamoDb
=== CONT TestAccAwsDmsEndpoint_Kafka_Topic
=== CONT TestAccAwsDmsEndpoint_S3
=== CONT TestAccAwsDmsEndpoint_Elasticsearch_FullLoadErrorPercentage
--- PASS: TestAccAwsDmsEndpoint_MongoDb (28.89s)
--- PASS: TestAccAwsDmsEndpoint_Elasticsearch_FullLoadErrorPercentage (41.59s)
--- PASS: TestAccAwsDmsEndpoint_S3_ExtraConnectionAttributes (41.69s)
--- PASS: TestAccAwsDmsEndpoint_Elasticsearch (43.47s)
--- PASS: TestAccAwsDmsEndpoint_Kafka_Broker (43.49s)
--- PASS: TestAccAwsDmsEndpoint_Kafka_Topic (43.72s)
--- PASS: TestAccAwsDmsEndpoint_basic (44.18s)
--- PASS: TestAccAwsDmsEndpoint_DocDB (44.35s)
--- PASS: TestAccAwsDmsEndpoint_Db2 (44.39s)
--- PASS: TestAccAwsDmsEndpoint_Elasticsearch_ErrorRetryDuration (45.88s)
--- PASS: TestAccAwsDmsEndpoint_MongoDb_Update (48.82s)
--- PASS: TestAccAwsDmsEndpoint_Elasticsearch_ExtraConnectionAttributes (50.84s)
--- PASS: TestAccAwsDmsEndpoint_DynamoDb (61.51s)
--- PASS: TestAccAwsDmsEndpoint_S3 (61.87s)
--- PASS: TestAccAwsDmsEndpoint_Kinesis (103.90s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 107.140s
@dsarrio Thanks for the contribution 🎉 👏. |
This functionality has been released in v3.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
AWS now supports more engines in dms endpoints. List of allowed values have been updated accordingly.
Reference:
Community Note
Closes #19150