-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/cloudformation_stack_set_instance: add support for organizations deployment targets
#21193
r/cloudformation_stack_set_instance: add support for organizations deployment targets
#21193
Conversation
983868d
to
83a6124
Compare
863e5a4
to
d4ecb50
Compare
6fc77e4
to
9b941b1
Compare
7daa778
to
89f2267
Compare
0a66266
to
8802bf6
Compare
8802bf6
to
38ea70d
Compare
0b53b1b
to
e51e82a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Commercial
% make testacc TESTARGS='-run=TestAccAWSCloudFormationStackSetInstance_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCloudFormationStackSetInstance_ -timeout 180m
=== RUN TestAccAWSCloudFormationStackSetInstance_basic
=== PAUSE TestAccAWSCloudFormationStackSetInstance_basic
=== RUN TestAccAWSCloudFormationStackSetInstance_disappears
=== PAUSE TestAccAWSCloudFormationStackSetInstance_disappears
=== RUN TestAccAWSCloudFormationStackSetInstance_disappears_StackSet
=== PAUSE TestAccAWSCloudFormationStackSetInstance_disappears_StackSet
=== RUN TestAccAWSCloudFormationStackSetInstance_ParameterOverrides
=== PAUSE TestAccAWSCloudFormationStackSetInstance_ParameterOverrides
=== RUN TestAccAWSCloudFormationStackSetInstance_RetainStack
=== PAUSE TestAccAWSCloudFormationStackSetInstance_RetainStack
=== RUN TestAccAWSCloudFormationStackSetInstance_DeploymentTargets
provider_test.go:58: API does not support enabling Organizations access (in particular, creating the Stack Sets IAM Service-Linked Role)
--- SKIP: TestAccAWSCloudFormationStackSetInstance_DeploymentTargets (0.00s)
=== CONT TestAccAWSCloudFormationStackSetInstance_basic
=== CONT TestAccAWSCloudFormationStackSetInstance_ParameterOverrides
=== CONT TestAccAWSCloudFormationStackSetInstance_RetainStack
=== CONT TestAccAWSCloudFormationStackSetInstance_disappears
=== CONT TestAccAWSCloudFormationStackSetInstance_disappears_StackSet
--- PASS: TestAccAWSCloudFormationStackSetInstance_disappears_StackSet (120.10s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_basic (122.67s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_disappears (127.64s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_RetainStack (200.34s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_ParameterOverrides (293.26s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 305.152s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSCloudFormationStackSetInstance_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCloudFormationStackSetInstance_ -timeout 180m
=== RUN TestAccAWSCloudFormationStackSetInstance_basic
=== PAUSE TestAccAWSCloudFormationStackSetInstance_basic
=== RUN TestAccAWSCloudFormationStackSetInstance_disappears
=== PAUSE TestAccAWSCloudFormationStackSetInstance_disappears
=== RUN TestAccAWSCloudFormationStackSetInstance_disappears_StackSet
=== PAUSE TestAccAWSCloudFormationStackSetInstance_disappears_StackSet
=== RUN TestAccAWSCloudFormationStackSetInstance_ParameterOverrides
=== PAUSE TestAccAWSCloudFormationStackSetInstance_ParameterOverrides
=== RUN TestAccAWSCloudFormationStackSetInstance_RetainStack
=== PAUSE TestAccAWSCloudFormationStackSetInstance_RetainStack
=== RUN TestAccAWSCloudFormationStackSetInstance_DeploymentTargets
provider_test.go:58: API does not support enabling Organizations access (in particular, creating the Stack Sets IAM Service-Linked Role)
--- SKIP: TestAccAWSCloudFormationStackSetInstance_DeploymentTargets (0.00s)
=== CONT TestAccAWSCloudFormationStackSetInstance_basic
=== CONT TestAccAWSCloudFormationStackSetInstance_ParameterOverrides
=== CONT TestAccAWSCloudFormationStackSetInstance_RetainStack
=== CONT TestAccAWSCloudFormationStackSetInstance_disappears
=== CONT TestAccAWSCloudFormationStackSetInstance_disappears_StackSet
--- PASS: TestAccAWSCloudFormationStackSetInstance_disappears_StackSet (125.31s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_disappears (126.00s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_basic (128.12s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_RetainStack (208.62s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_ParameterOverrides (260.59s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 268.478s
This functionality has been released in v3.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #12425
Output from acceptance testing (commercial):
Output from acceptance testing (organizations-only account):