-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added teletext destinations settings #33797
added teletext destinations settings #33797
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Hey @peletv2 👋 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.) |
Due to our organization policy, we aren't able to allow you to make direct edits. |
bdb8075
to
a25e0d9
Compare
I just rebased in order to stay up to date with main, making sure there are no conflicts. |
Thank you for your contribution! 🚀 Please note that the Remove any changes to the |
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
fb16958
to
bdb8075
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make t T=TestAccMediaLiveChannel_captionDescriptions K=medialive
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/medialive/... -v -count 1 -parallel 20 -run='TestAccMediaLiveChannel_captionDescriptions' -timeout 360m
=== RUN TestAccMediaLiveChannel_captionDescriptions
=== PAUSE TestAccMediaLiveChannel_captionDescriptions
=== CONT TestAccMediaLiveChannel_captionDescriptions
--- PASS: TestAccMediaLiveChannel_captionDescriptions (70.96s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/medialive 73.493s
This functionality has been released in v5.82.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
Added missing
teletext_destinations_settings
tocaptions_descriptions
.It's just an empty struct so that's what I left it at. docs
Even though it's just an empty struct, it's needed because of diff. In the current state where it isn't added, it'll notice it as a change every time.
Relations
References
Output from Acceptance Testing