Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added teletext destinations settings #33797

Conversation

peletv2
Copy link
Contributor

@peletv2 peletv2 commented Oct 6, 2023

Description

Added missing teletext_destinations_settings to captions_descriptions.

It's just an empty struct so that's what I left it at. docs

Even though it's just an empty struct, it's needed because of diff. In the current state where it isn't added, it'll notice it as a change every time.

Relations

References

Output from Acceptance Testing

% make testacc TESTS=TestAccMediaLiveChannel_captionDescriptions PKG=medialive
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/medialive/... -v -count 1 -parallel 20 -run='TestAccMediaLiveChannel_captionDescriptions'  -timeout 360m
=== RUN   TestAccMediaLiveChannel_captionDescriptions
=== PAUSE TestAccMediaLiveChannel_captionDescriptions
=== CONT  TestAccMediaLiveChannel_captionDescriptions
--- PASS: TestAccMediaLiveChannel_captionDescriptions (64.19s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/medialive	66.318s
...

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/medialive Issues and PRs that pertain to the medialive service. labels Oct 6, 2023
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Hey @peletv2 👋 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.)

@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 6, 2023
@peletv2 peletv2 marked this pull request as ready for review October 6, 2023 10:26
@peletv2
Copy link
Contributor Author

peletv2 commented Oct 16, 2023

Due to our organization policy, we aren't able to allow you to make direct edits.

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 25, 2023
@peletv2 peletv2 force-pushed the b-aws_medialive_channel_captions_teletext_destination_settings branch from bdb8075 to a25e0d9 Compare December 14, 2023 10:18
@peletv2
Copy link
Contributor Author

peletv2 commented Dec 14, 2023

I just rebased in order to stay up to date with main, making sure there are no conflicts.

Copy link

Thank you for your contribution! 🚀

Please note that the CHANGELOG.md file contents are handled by the maintainers during merge. This is to prevent pull request merge conflicts, especially for contributions which may not be merged immediately. Please see the Contributing Guide for additional pull request review items.

Remove any changes to the CHANGELOG.md file and commit them in this pull request to prevent delays with reviewing and potentially merging this pull request.

Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@peletv2 peletv2 force-pushed the b-aws_medialive_channel_captions_teletext_destination_settings branch from fb16958 to bdb8075 Compare February 27, 2024 14:59
@YakDriver YakDriver self-assigned this Dec 13, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 13, 2024
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make t T=TestAccMediaLiveChannel_captionDescriptions K=medialive
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/medialive/... -v -count 1 -parallel 20 -run='TestAccMediaLiveChannel_captionDescriptions'  -timeout 360m
=== RUN   TestAccMediaLiveChannel_captionDescriptions
=== PAUSE TestAccMediaLiveChannel_captionDescriptions
=== CONT  TestAccMediaLiveChannel_captionDescriptions
--- PASS: TestAccMediaLiveChannel_captionDescriptions (70.96s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/medialive	73.493s

@YakDriver YakDriver merged commit d14bccc into hashicorp:main Dec 13, 2024
52 checks passed
@github-actions github-actions bot added this to the v5.82.0 milestone Dec 13, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 19, 2024
Copy link

This functionality has been released in v5.82.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Addresses a defect in current functionality. service/medialive Issues and PRs that pertain to the medialive service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants