Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Datasource aws_servicecatalogappregistry_attribute_group_associations #38306

Merged
merged 27 commits into from
Dec 16, 2024
Merged

New Datasource aws_servicecatalogappregistry_attribute_group_associations #38306

merged 27 commits into from
Dec 16, 2024

Conversation

drewtul
Copy link
Contributor

@drewtul drewtul commented Jul 9, 2024 •
edited
Loading

Description

New datasource aws_servicecatalogappregistry_attribute_group_associations to list the attribute groups an application is associated with in Service Catalog AppRegistry

Relations

Depends on: #38290

References

Output from Acceptance Testing

%    make testacc TESTS=TestAccServiceCatalogAppRegistryAttributeGroupAssociationsDataSource_ PKG=servicecatalogappregistry
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/servicecatalogappregistry/... -v -count 1 -parallel 20 -run='TestAccServiceCatalogAppRegistryAttributeGroupAssociationsDataSource_'  -timeout 360m
2024/12/10 14:29:03 Initializing Terraform AWS Provider...
=== RUN   TestAccServiceCatalogAppRegistryAttributeGroupAssociationsDataSource_basic
=== PAUSE TestAccServiceCatalogAppRegistryAttributeGroupAssociationsDataSource_basic
=== CONT  TestAccServiceCatalogAppRegistryAttributeGroupAssociationsDataSource_basic
--- PASS: TestAccServiceCatalogAppRegistryAttributeGroupAssociationsDataSource_basic (20.53s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalogappregistry  27.666s

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/servicecatalogappregistry Issues and PRs that pertain to the servicecatalogappregistry service. and removed size/XL Managed by automation to categorize the size of a PR. labels Jul 9, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Jul 9, 2024
@justinretzolk justinretzolk added the new-data-source Introduces a new data source. label Jul 9, 2024
@drewtul drewtul marked this pull request as ready for review July 9, 2024 16:55
@drewtul drewtul requested a review from a team as a code owner July 9, 2024 16:55
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Jul 9, 2024
@drewtul drewtul force-pushed the f-sc-appregistry-app-ag-associations-ds branch 3 times, most recently from 9351fa7 to d5eba8b Compare December 5, 2024 16:49
@drewtul drewtul force-pushed the f-sc-appregistry-app-ag-associations-ds branch from d5eba8b to 9112241 Compare December 9, 2024 20:20
@drewtul drewtul force-pushed the f-sc-appregistry-app-ag-associations-ds branch from 9112241 to 602bc50 Compare December 9, 2024 22:11
@drewtul drewtul changed the title New Datasource aws_servicecatalogappregistry_application_attribute_group_associations New Datasource aws_servicecatalogappregistry_application_attribute_groups Dec 10, 2024
@drewtul drewtul changed the title New Datasource aws_servicecatalogappregistry_application_attribute_groups New Datasource aws_servicecatalogappregistry_attribute_group_associations Dec 10, 2024
@jar-b jar-b self-assigned this Dec 10, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 10, 2024
drewtul and others added 8 commits December 10, 2024 15:15
@drewtul
rename docs
876a7b6
@jar-b
Merge branch 'main' into f-sc-appregistry-app-ag-associations-ds
edc6697
@jar-b
d/aws_servicecatalogappregistry_attribute_group_associations: tidy na…
4ee86f8 
…ming
@jar-b
d/aws_servicecatalogappregistry_attribute_group_associations(doc): ti…
7748e52 
…dy naming, descriptions:
@jar-b
d/aws_servicecatalogappregistry_attribute_group_associations: add con…
a965053 
…fig validator

```console
% make testacc PKG=servicecatalogappregistry TESTS=TestAccServiceCatalogAppRegistryAttributeGroupAssociationsDataSource_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/servicecatalogappregistry/... -v -count 1 -parallel 20 -run='TestAccServiceCatalogAppRegistryAttributeGroupAssociationsDataSource_'  -timeout 360m
2024/12/16 11:24:50 Initializing Terraform AWS Provider...

--- PASS: TestAccServiceCatalogAppRegistryAttributeGroupAssociationsDataSource_basic (13.58s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalogappregistry  18.643s
```
@jar-b
d/aws_servicecatalogappregistry_attribute_group_associations: use pag…
1afca79 
…inator

This ensures all pages are ready by the `List` API.
@jar-b
d/aws_servicecatalogappregistry_attribute_group_associations(test): s…
c51a70d 
…elf contained test config

```console
% make testacc PKG=servicecatalogappregistry TESTS=TestAccServiceCatalogAppRegistryAttributeGroupAssociationsDataSource_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/servicecatalogappregistry/... -v -count 1 -parallel 20 -run='TestAccServiceCatalogAppRegistryAttributeGroupAssociationsDataSource_'  -timeout
360m
2024/12/16 12:17:19 Initializing Terraform AWS Provider...

--- PASS: TestAccServiceCatalogAppRegistryAttributeGroupAssociationsDataSource_basic (13.09s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalogappregistry  18.221s
```
@jar-b
d/aws_servicecatalogappregistry_attribute_group_associations(doc): fi…
3764135 
…x typos
jar-b
jar-b approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=servicecatalogappregistry TESTS=TestAccServiceCatalogAppRegistryAttributeGroupAssociationsDataSource_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/servicecatalogappregistry/... -v -count 1 -parallel 20 -run='TestAccServiceCatalogAppRegistryAttributeGroupAssociationsDataSource_'  -timeout
360m
2024/12/16 12:17:19 Initializing Terraform AWS Provider...

--- PASS: TestAccServiceCatalogAppRegistryAttributeGroupAssociationsDataSource_basic (13.09s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalogappregistry  18.221s

@jar-b
Copy link
Member

jar-b commented Dec 16, 2024

Thanks for your contribution, @drewtul! 🚀

@jar-b jar-b merged commit c45a7d8 into hashicorp:main Dec 16, 2024
42 checks passed
@github-actions github-actions bot added this to the v5.82.0 milestone Dec 16, 2024
@drewtul drewtul deleted the f-sc-appregistry-app-ag-associations-ds branch December 17, 2024 16:54
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 19, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.82.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YakDriver YakDriver YakDriver approved these changes

@jar-b jar-b jar-b approved these changes

Assignees

@jar-b jar-b

Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. partner Contribution from a partner. service/servicecatalogappregistry Issues and PRs that pertain to the servicecatalogappregistry service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.82.0
Development

Successfully merging this pull request may close these issues.
4 participants
@drewtul @jar-b @YakDriver @justinretzolk