New Resource: aws_cloudfront_vpc_origin #40239

itsnicksia · 2024-11-21T15:36:03Z

Description

This change adds the new "Cloudfront VPC Origin" resource.

Relations

References

https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/cloudfront#Client.CreateVpcOrigin
https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/cloudfront#Client.DeleteVpcOrigin
https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/cloudfront#Client.GetVpcOrigin
https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/cloudfront#Client.ListVpcOrigins
https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/cloudfront#Client.UpdateVpcOrigin

Output from Acceptance Testing

TODO

github-actions · 2024-11-21T15:36:18Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

github-actions

Welcome @itsnicksia 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

itsnicksia · 2024-11-23T17:12:44Z

Create working:

itsnicksia · 2024-11-23T17:53:13Z

Added simple implementations of Read, Update and Delete.

These are still fragile and needs proper error handling.

Tests and documentation are not yet done.

nicksia-vgw · 2024-11-30T11:31:45Z

Fixing up the SSL Origin Protocol syntax then going onto Tests and Docs.

nicksia-vgw · 2024-12-03T07:36:58Z

Docs updated.

Working on acceptance tests...

% make testacc TESTARGS='-run=TestAccCloudFrontVPCOrigin_basic' PKG=cloudfront make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.23.3 test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run=TestAccCloudFrontVPCOrigin_basic -timeout 360m 2024/12/17 14:47:44 Initializing Terraform AWS Provider... === RUN TestAccCloudFrontVPCOrigin_basic === PAUSE TestAccCloudFrontVPCOrigin_basic === CONT TestAccCloudFrontVPCOrigin_basic --- PASS: TestAccCloudFrontVPCOrigin_basic (991.04s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront 996.513s

…gin_tags.

ewbankkit

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCloudFrontVPCOrigin_' PKG=cloudfront ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/cloudfront/... -v -count 1 -parallel 4  -run=TestAccCloudFrontVPCOrigin_ -timeout 360m
2024/12/17 16:47:16 Initializing Terraform AWS Provider...
=== RUN   TestAccCloudFrontVPCOrigin_basic
=== PAUSE TestAccCloudFrontVPCOrigin_basic
=== RUN   TestAccCloudFrontVPCOrigin_disappears
=== PAUSE TestAccCloudFrontVPCOrigin_disappears
=== RUN   TestAccCloudFrontVPCOrigin_update
=== PAUSE TestAccCloudFrontVPCOrigin_update
=== RUN   TestAccCloudFrontVPCOrigin_tags
=== PAUSE TestAccCloudFrontVPCOrigin_tags
=== CONT  TestAccCloudFrontVPCOrigin_basic
=== CONT  TestAccCloudFrontVPCOrigin_update
=== CONT  TestAccCloudFrontVPCOrigin_disappears
=== CONT  TestAccCloudFrontVPCOrigin_tags
--- PASS: TestAccCloudFrontVPCOrigin_basic (738.19s)
--- PASS: TestAccCloudFrontVPCOrigin_update (740.90s)
--- PASS: TestAccCloudFrontVPCOrigin_tags (741.42s)
--- PASS: TestAccCloudFrontVPCOrigin_disappears (746.68s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	752.020s

% make testacc TESTARGS='-run=TestAccCloudFrontDistribution_noOptionalItems\|TestAccCloudFrontDistribution_vpcOriginConfig' PKG=cloudfront
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/cloudfront/... -v -count 1 -parallel 20  -run=TestAccCloudFrontDistribution_noOptionalItems\|TestAccCloudFrontDistribution_vpcOriginConfig -timeout 360m
2024/12/18 08:31:18 Initializing Terraform AWS Provider...
=== RUN   TestAccCloudFrontDistribution_noOptionalItems
=== PAUSE TestAccCloudFrontDistribution_noOptionalItems
=== RUN   TestAccCloudFrontDistribution_vpcOriginConfig
=== PAUSE TestAccCloudFrontDistribution_vpcOriginConfig
=== CONT  TestAccCloudFrontDistribution_noOptionalItems
=== CONT  TestAccCloudFrontDistribution_vpcOriginConfig
--- PASS: TestAccCloudFrontDistribution_noOptionalItems (671.02s)
--- PASS: TestAccCloudFrontDistribution_vpcOriginConfig (921.69s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	927.226s

nicksia-vgw · 2024-12-17T22:40:06Z

Thanks for the fixes Kit!

Will review those so I don't make the same mistakes in future.

Did you want

aws_cloudfront_distribution.origin.vpc_origin_config

In this PR or a separate one?

ewbankkit · 2024-12-18T13:02:18Z

@nicksia-vgw I will add the change to this PR so that we can get it released this week. Thanks.

jar-b

LGTM 🎉

% make testacc PKG=cloudfront TESTS="TestAccCloudFrontDistribution_noOptionalItems|TestAccCloudFrontDistribution_vpcOriginConfig"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run='TestAccCloudFrontDistribution_noOptionalItems|TestAccCloudFrontDistribution_vpcOriginConfig'  -timeout 360m
2024/12/18 09:47:31 Initializing Terraform AWS Provider...
=== RUN   TestAccCloudFrontDistribution_noOptionalItems
=== PAUSE TestAccCloudFrontDistribution_noOptionalItems
=== RUN   TestAccCloudFrontDistribution_vpcOriginConfig
=== PAUSE TestAccCloudFrontDistribution_vpcOriginConfig
=== CONT  TestAccCloudFrontDistribution_noOptionalItems
=== CONT  TestAccCloudFrontDistribution_vpcOriginConfig
--- PASS: TestAccCloudFrontDistribution_noOptionalItems (474.54s)
--- PASS: TestAccCloudFrontDistribution_vpcOriginConfig (911.16s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront 920.068s

% make testacc PKG=cloudfront TESTS=TestAccCloudFrontVPCOrigin_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run='TestAccCloudFrontVPCOrigin_'  -timeout 360m
2024/12/18 09:47:28 Initializing Terraform AWS Provider...
=== RUN   TestAccCloudFrontVPCOrigin_basic
=== PAUSE TestAccCloudFrontVPCOrigin_basic
=== RUN   TestAccCloudFrontVPCOrigin_disappears
=== PAUSE TestAccCloudFrontVPCOrigin_disappears
=== RUN   TestAccCloudFrontVPCOrigin_update
=== PAUSE TestAccCloudFrontVPCOrigin_update
=== RUN   TestAccCloudFrontVPCOrigin_tags
=== PAUSE TestAccCloudFrontVPCOrigin_tags
=== CONT  TestAccCloudFrontVPCOrigin_basic
=== CONT  TestAccCloudFrontVPCOrigin_update
=== CONT  TestAccCloudFrontVPCOrigin_disappears
=== CONT  TestAccCloudFrontVPCOrigin_tags
--- PASS: TestAccCloudFrontVPCOrigin_disappears (911.28s)
--- PASS: TestAccCloudFrontVPCOrigin_basic (913.95s)
--- PASS: TestAccCloudFrontVPCOrigin_update (916.28s)
--- PASS: TestAccCloudFrontVPCOrigin_tags (916.72s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront 923.298s

ewbankkit · 2024-12-18T15:14:31Z

@itsnicksia Thanks for the contribution 🎉 👏.

github-actions · 2024-12-19T18:17:05Z

This functionality has been released in v5.82.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

r/aws_cloudfront_vpc_origin: initial resource stub

dc7bddc

github-actions bot added service/cloudfront Issues and PRs that pertain to the cloudfront service. needs-triage Waiting for first response or review from a maintainer. labels Nov 21, 2024

register resource

2c41a33

itsnicksia mentioned this pull request Nov 21, 2024

[Enhancement]: Support for CloudFront VPC Origins #40234

Closed

github-actions bot reviewed Nov 21, 2024

View reviewed changes

github-actions bot added the generators Relates to code generators. label Nov 21, 2024

itsnicksia added 2 commits November 22, 2024 00:00

add resource attributes

dba7961

add schema

987c893

itsnicksia mentioned this pull request Nov 22, 2024

[WIP] New Resource: aws_cloudfront_vpc_origin_endpoint_configuration #40252

Closed

itsnicksia added 2 commits November 23, 2024 00:26

implement resource create

9fd8a09

fix schema

216e201

add simple read, update, delete

29b7791

itsnicksia and others added 8 commits November 25, 2024 21:39

test wip

8f06f20

add stub documentation

4cfbe50

add list api

6796ba4

add test helpers

aa8a208

add delete wait

d7970fd

add waiter for create, update

899d8cf

add default timeouts

2ee98ba

fix waiters and errors

98ddcf9

itsnicksia added 2 commits December 1, 2024 22:47

test wip

6c81bb1

update docs

3425979

nicksia-vgw added 2 commits December 9, 2024 00:30

fix bug in waiter

95fcc7f

add destroy check to test and add note for current issue

908f2b6

ewbankkit added 9 commits December 17, 2024 10:29

No need for extra constant definitions.

3b6f149

Add 'fwtypes.ListOfStringEnumType'.

2a8273b

r/aws_cloudfront_vpc_origin: Tidy up.

7b3a955

Fix crash.

5f461ff

r/aws_cloudfront_vpc_origin: Corrections.

556a1fe

Tweak 'TestAccCloudFrontVPCOrigin_basic'.

fba5a34

Add 'TestAccCloudFrontVPCOrigin_disappears'.

97bf65a

Add 'TestAccCloudFrontVPCOrigin_update' and ''TestAccCloudFrontVPCOri…

c7fe29d

…gin_tags.

ewbankkit changed the title ~~[WIP] New Resource: aws_cloudfront_vpc_origin~~ New Resource: aws_cloudfront_vpc_origin Dec 17, 2024

ewbankkit added the new-resource Introduces a new resource. label Dec 17, 2024

github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 17, 2024

r/aws_cloudfront_vpc_origin: Add sweeper.

c77c9fe

ewbankkit previously approved these changes Dec 17, 2024

View reviewed changes

This comment was marked as resolved.

Sign in to view

ewbankkit added 2 commits December 18, 2024 08:05

Merge branch 'main' into HEAD

1e19be2

r/aws_cloudfront_distribution: Add origin.vpc_origin_config argument.

5dba2a5

ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 18, 2024

ewbankkit dismissed their stale review via 5dba2a5 December 18, 2024 13:51

jar-b approved these changes Dec 18, 2024

View reviewed changes

ewbankkit merged commit f8f77af into hashicorp:main Dec 18, 2024
41 checks passed

github-actions bot added this to the v5.82.0 milestone Dec 18, 2024

github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 19, 2024

destornillador mentioned this pull request Dec 21, 2024

feat!: Bump AWS provider version to 5.82, added VPC Origin support terraform-aws-modules/terraform-aws-cloudfront#153

Merged

3 tasks

chaya2z mentioned this pull request Dec 22, 2024

docs: fix example import block by quoting #40673

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resource: aws_cloudfront_vpc_origin #40239

New Resource: aws_cloudfront_vpc_origin #40239

itsnicksia commented Nov 21, 2024 •

edited by ewbankkit

Loading

github-actions bot commented Nov 21, 2024

github-actions bot left a comment

itsnicksia commented Nov 23, 2024

itsnicksia commented Nov 23, 2024 •

edited

Loading

nicksia-vgw commented Nov 30, 2024

nicksia-vgw commented Dec 3, 2024

ewbankkit left a comment •

edited

Loading

This comment was marked as resolved.

nicksia-vgw commented Dec 17, 2024

ewbankkit commented Dec 18, 2024

jar-b left a comment

ewbankkit commented Dec 18, 2024

github-actions bot commented Dec 19, 2024

New Resource: aws_cloudfront_vpc_origin #40239

New Resource: aws_cloudfront_vpc_origin #40239

Conversation

itsnicksia commented Nov 21, 2024 • edited by ewbankkit Loading

Description

Relations

References

Output from Acceptance Testing

github-actions bot commented Nov 21, 2024

Community Note

github-actions bot left a comment

Choose a reason for hiding this comment

itsnicksia commented Nov 23, 2024

itsnicksia commented Nov 23, 2024 • edited Loading

nicksia-vgw commented Nov 30, 2024

nicksia-vgw commented Dec 3, 2024

ewbankkit left a comment • edited Loading

Choose a reason for hiding this comment

This comment was marked as resolved.

nicksia-vgw commented Dec 17, 2024

ewbankkit commented Dec 18, 2024

jar-b left a comment

Choose a reason for hiding this comment

ewbankkit commented Dec 18, 2024

github-actions bot commented Dec 19, 2024

itsnicksia commented Nov 21, 2024 •

edited by ewbankkit

Loading

itsnicksia commented Nov 23, 2024 •

edited

Loading

ewbankkit left a comment •

edited

Loading