Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add agent_collaboration property to aws_bedrockagent_agent #40543

Merged
merged 7 commits into from
Dec 16, 2024

Conversation

drewtul
Copy link
Contributor

@drewtul drewtul commented Dec 12, 2024

Description

This adds the agent_collaboration property to allow multi-agent collaboration feature, will require additional resources to finish out the capability completely.

Relations

References

Output from Acceptance Testing

%  make testacc TESTS=TestAccBedrockAgentAgent_ PKG=bedrockagent
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/bedrockagent/... -v -count 1 -parallel 20 -run='TestAccBedrockAgentAgent_'  -timeout 360m
2024/12/12 11:11:59 Initializing Terraform AWS Provider...
=== RUN   TestAccBedrockAgentAgent_basic
=== PAUSE TestAccBedrockAgentAgent_basic
=== RUN   TestAccBedrockAgentAgent_full
=== PAUSE TestAccBedrockAgentAgent_full
=== RUN   TestAccBedrockAgentAgent_singlePrompt
=== PAUSE TestAccBedrockAgentAgent_singlePrompt
=== RUN   TestAccBedrockAgentAgent_singlePromptUpdate
=== PAUSE TestAccBedrockAgentAgent_singlePromptUpdate
=== RUN   TestAccBedrockAgentAgent_addPrompt
=== PAUSE TestAccBedrockAgentAgent_addPrompt
=== RUN   TestAccBedrockAgentAgent_guardrail
=== PAUSE TestAccBedrockAgentAgent_guardrail
=== RUN   TestAccBedrockAgentAgent_update
=== PAUSE TestAccBedrockAgentAgent_update
=== RUN   TestAccBedrockAgentAgent_tags
=== PAUSE TestAccBedrockAgentAgent_tags
=== RUN   TestAccBedrockAgentAgent_kms
=== PAUSE TestAccBedrockAgentAgent_kms
=== RUN   TestAccBedrockAgentAgent_collaboration
=== PAUSE TestAccBedrockAgentAgent_collaboration
=== CONT  TestAccBedrockAgentAgent_basic
=== CONT  TestAccBedrockAgentAgent_guardrail
=== CONT  TestAccBedrockAgentAgent_kms
=== CONT  TestAccBedrockAgentAgent_collaboration
=== CONT  TestAccBedrockAgentAgent_tags
=== CONT  TestAccBedrockAgentAgent_update
=== CONT  TestAccBedrockAgentAgent_singlePromptUpdate
=== CONT  TestAccBedrockAgentAgent_addPrompt
=== CONT  TestAccBedrockAgentAgent_singlePrompt
=== CONT  TestAccBedrockAgentAgent_full
--- PASS: TestAccBedrockAgentAgent_basic (33.58s)
--- PASS: TestAccBedrockAgentAgent_singlePrompt (35.29s)
--- PASS: TestAccBedrockAgentAgent_full (35.41s)
--- PASS: TestAccBedrockAgentAgent_collaboration (46.75s)
--- PASS: TestAccBedrockAgentAgent_singlePromptUpdate (48.58s)
--- PASS: TestAccBedrockAgentAgent_kms (52.15s)
--- PASS: TestAccBedrockAgentAgent_tags (63.65s)
--- PASS: TestAccBedrockAgentAgent_update (64.06s)
--- PASS: TestAccBedrockAgentAgent_guardrail (77.66s)
--- PASS: TestAccBedrockAgentAgent_addPrompt (80.84s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/bedrockagent       85.471s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Dec 12, 2024
@drewtul drewtul marked this pull request as ready for review December 12, 2024 11:54
@drewtul drewtul requested a review from a team as a code owner December 12, 2024 11:54
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 12, 2024
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=bedrockagent TESTS=TestAccBedrockAgentAgent_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/bedrockagent/... -v -count 1 -parallel 20 -run='TestAccBedrockAgentAgent_'  -timeout 360m
2024/12/16 10:19:06 Initializing Terraform AWS Provider...

--- PASS: TestAccBedrockAgentAgent_basic (25.50s)
--- PASS: TestAccBedrockAgentAgent_full (27.51s)
--- PASS: TestAccBedrockAgentAgent_singlePrompt (29.39s)
--- PASS: TestAccBedrockAgentAgent_singlePromptUpdate (38.32s)
--- PASS: TestAccBedrockAgentAgent_agentCollaboration (38.40s)
--- PASS: TestAccBedrockAgentAgent_kms (42.99s)
--- PASS: TestAccBedrockAgentAgent_update (48.85s)
--- PASS: TestAccBedrockAgentAgent_tags (49.73s)
--- PASS: TestAccBedrockAgentAgent_addPrompt (62.66s)
--- PASS: TestAccBedrockAgentAgent_guardrail (63.33s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/bedrockagent       68.523s

@jar-b
Copy link
Member

jar-b commented Dec 16, 2024

Thanks for your contribution, @drewtul! 👍

Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jar-b jar-b merged commit c5b3acd into hashicorp:main Dec 16, 2024
42 checks passed
@github-actions github-actions bot added this to the v5.82.0 milestone Dec 16, 2024
@drewtul drewtul deleted the f-bedrock-agent-collab branch December 17, 2024 16:55
Copy link

This functionality has been released in v5.82.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. partner Contribution from a partner. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants