Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tls cert for aws_codeconnections_host #40574

Merged
merged 5 commits into from
Dec 16, 2024

Conversation

silvaalbert
Copy link
Contributor

@silvaalbert silvaalbert commented Dec 16, 2024

Description

This PR fixes the tls_certificate attribute in aws_codeconnections_host, making it optional.

Relations

Closes #40573

References

https://docs.aws.amazon.com/codeconnections/latest/APIReference/API_VpcConfiguration.html

Output from Acceptance Testing

make testacc TESTS=TestAccCodeConnectionsHost_ PKG=codeconnections 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/codeconnections/... -v -count 1 -parallel 20 -run='TestAccCodeConnectionsHost_'  -timeout 360m
2024/12/16 09:26:38 Initializing Terraform AWS Provider...
=== RUN   TestAccCodeConnectionsHost_basic
=== PAUSE TestAccCodeConnectionsHost_basic
=== RUN   TestAccCodeConnectionsHost_disappears
=== PAUSE TestAccCodeConnectionsHost_disappears
=== RUN   TestAccCodeConnectionsHost_vpc
=== PAUSE TestAccCodeConnectionsHost_vpc
=== RUN   TestAccCodeConnectionsHost_tags
=== PAUSE TestAccCodeConnectionsHost_tags
=== CONT  TestAccCodeConnectionsHost_basic
=== CONT  TestAccCodeConnectionsHost_vpc
=== CONT  TestAccCodeConnectionsHost_disappears
=== CONT  TestAccCodeConnectionsHost_tags
--- PASS: TestAccCodeConnectionsHost_disappears (12.07s)
--- PASS: TestAccCodeConnectionsHost_basic (13.99s)
--- PASS: TestAccCodeConnectionsHost_tags (27.98s)
--- PASS: TestAccCodeConnectionsHost_vpc (507.85s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codeconnections	513.836s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/codeconnections Issues and PRs that pertain to the codeconnections service. needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Dec 16, 2024
@silvaalbert silvaalbert marked this pull request as ready for review December 16, 2024 14:37
@silvaalbert silvaalbert requested a review from a team as a code owner December 16, 2024 14:37
@silvaalbert
Copy link
Contributor Author

@ewbankkit sending this one your way since you helped with the original. Minor/quick fix. Thanks!

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Dec 16, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCodeConnectionsHost_vpc' PKG=codeconnections
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/codeconnections/... -v -count 1 -parallel 20  -run=TestAccCodeConnectionsHost_vpc -timeout 360m
2024/12/16 12:08:56 Initializing Terraform AWS Provider...
=== RUN   TestAccCodeConnectionsHost_vpc
=== PAUSE TestAccCodeConnectionsHost_vpc
=== CONT  TestAccCodeConnectionsHost_vpc
--- PASS: TestAccCodeConnectionsHost_vpc (582.10s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codeconnections	587.653s
% make testacc TESTARGS='-run=TestAccCodeConnectionsHost_basic' PKG=codeconnections
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/codeconnections/... -v -count 1 -parallel 20  -run=TestAccCodeConnectionsHost_basic -timeout 360m
2024/12/16 12:43:07 Initializing Terraform AWS Provider...
=== RUN   TestAccCodeConnectionsHost_basic
=== PAUSE TestAccCodeConnectionsHost_basic
=== CONT  TestAccCodeConnectionsHost_basic
--- PASS: TestAccCodeConnectionsHost_basic (13.64s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codeconnections	18.805s

@ewbankkit ewbankkit self-assigned this Dec 16, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 16, 2024
@ewbankkit ewbankkit merged commit 60b9248 into hashicorp:main Dec 16, 2024
41 checks passed
@ewbankkit
Copy link
Contributor

@silvaalbert Thanks for the contribution 🎉 👏.

@github-actions github-actions bot added this to the v5.82.0 milestone Dec 16, 2024
Copy link

This functionality has been released in v5.82.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
partner Contribution from a partner. service/codeconnections Issues and PRs that pertain to the codeconnections service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: tls_certificate for aws_codeconnections_host should be optional
4 participants