-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix tls cert for aws_codeconnections_host
#40574
fix tls cert for aws_codeconnections_host
#40574
Conversation
Community NoteVoting for Prioritization
For Submitters
|
@ewbankkit sending this one your way since you helped with the original. Minor/quick fix. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccCodeConnectionsHost_vpc' PKG=codeconnections
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/codeconnections/... -v -count 1 -parallel 20 -run=TestAccCodeConnectionsHost_vpc -timeout 360m
2024/12/16 12:08:56 Initializing Terraform AWS Provider...
=== RUN TestAccCodeConnectionsHost_vpc
=== PAUSE TestAccCodeConnectionsHost_vpc
=== CONT TestAccCodeConnectionsHost_vpc
--- PASS: TestAccCodeConnectionsHost_vpc (582.10s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/codeconnections 587.653s
% make testacc TESTARGS='-run=TestAccCodeConnectionsHost_basic' PKG=codeconnections
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/codeconnections/... -v -count 1 -parallel 20 -run=TestAccCodeConnectionsHost_basic -timeout 360m
2024/12/16 12:43:07 Initializing Terraform AWS Provider...
=== RUN TestAccCodeConnectionsHost_basic
=== PAUSE TestAccCodeConnectionsHost_basic
=== CONT TestAccCodeConnectionsHost_basic
--- PASS: TestAccCodeConnectionsHost_basic (13.64s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/codeconnections 18.805s
@silvaalbert Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.82.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
This PR fixes the
tls_certificate
attribute inaws_codeconnections_host
, making it optional.Relations
Closes #40573
References
https://docs.aws.amazon.com/codeconnections/latest/APIReference/API_VpcConfiguration.html
Output from Acceptance Testing