rds: import name_prefix for aws_db_parameter_group

[sp-jcberleur]

Description

Use the shared naming module to match the name and the prefix.
Acceptance test was updated to test the import.

Relations

Reference #24687
Closes #38014

Output from Acceptance Testing

TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSParameterGroup_'  -timeout 360m
2024/12/18 11:31:59 Initializing Terraform AWS Provider...
=== RUN   TestAccRDSParameterGroup_basic
=== PAUSE TestAccRDSParameterGroup_basic
=== RUN   TestAccRDSParameterGroup_disappears
=== PAUSE TestAccRDSParameterGroup_disappears
=== RUN   TestAccRDSParameterGroup_tags
=== PAUSE TestAccRDSParameterGroup_tags
=== RUN   TestAccRDSParameterGroup_caseWithMixedParameters
=== PAUSE TestAccRDSParameterGroup_caseWithMixedParameters
=== RUN   TestAccRDSParameterGroup_limit
=== PAUSE TestAccRDSParameterGroup_limit
=== RUN   TestAccRDSParameterGroup_namePrefix
=== PAUSE TestAccRDSParameterGroup_namePrefix
=== RUN   TestAccRDSParameterGroup_generatedName
=== PAUSE TestAccRDSParameterGroup_generatedName
=== RUN   TestAccRDSParameterGroup_withApplyMethod
=== PAUSE TestAccRDSParameterGroup_withApplyMethod
=== RUN   TestAccRDSParameterGroup_only
=== PAUSE TestAccRDSParameterGroup_only
=== RUN   TestAccRDSParameterGroup_matchDefault
=== PAUSE TestAccRDSParameterGroup_matchDefault
=== RUN   TestAccRDSParameterGroup_updateParameters
=== PAUSE TestAccRDSParameterGroup_updateParameters
=== RUN   TestAccRDSParameterGroup_updateParameters2
=== PAUSE TestAccRDSParameterGroup_updateParameters2
=== RUN   TestAccRDSParameterGroup_caseParameters
=== PAUSE TestAccRDSParameterGroup_caseParameters
=== RUN   TestAccRDSParameterGroup_skipDestroy
=== PAUSE TestAccRDSParameterGroup_skipDestroy
=== CONT  TestAccRDSParameterGroup_basic
=== CONT  TestAccRDSParameterGroup_only
=== CONT  TestAccRDSParameterGroup_matchDefault
=== CONT  TestAccRDSParameterGroup_updateParameters2
=== CONT  TestAccRDSParameterGroup_limit
=== CONT  TestAccRDSParameterGroup_skipDestroy
=== CONT  TestAccRDSParameterGroup_updateParameters
=== CONT  TestAccRDSParameterGroup_withApplyMethod
=== CONT  TestAccRDSParameterGroup_generatedName
=== CONT  TestAccRDSParameterGroup_namePrefix
=== CONT  TestAccRDSParameterGroup_tags
=== CONT  TestAccRDSParameterGroup_caseWithMixedParameters
=== CONT  TestAccRDSParameterGroup_disappears
=== CONT  TestAccRDSParameterGroup_caseParameters
--- PASS: TestAccRDSParameterGroup_skipDestroy (95.72s)
--- PASS: TestAccRDSParameterGroup_generatedName (109.01s)
--- PASS: TestAccRDSParameterGroup_withApplyMethod (119.28s)
--- PASS: TestAccRDSParameterGroup_disappears (125.99s)
--- PASS: TestAccRDSParameterGroup_namePrefix (135.86s)
--- PASS: TestAccRDSParameterGroup_only (140.03s)
--- PASS: TestAccRDSParameterGroup_caseParameters (147.37s)
--- PASS: TestAccRDSParameterGroup_caseWithMixedParameters (149.19s)
--- PASS: TestAccRDSParameterGroup_updateParameters2 (163.96s)
--- PASS: TestAccRDSParameterGroup_matchDefault (164.55s)
--- PASS: TestAccRDSParameterGroup_updateParameters (168.80s)
--- PASS: TestAccRDSParameterGroup_limit (170.76s)
--- PASS: TestAccRDSParameterGroup_tags (183.26s)
--- PASS: TestAccRDSParameterGroup_basic (195.90s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        205.197s
...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @sp-jcberleur 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRDSParameterGroup_basic\|TestAccRDSParameterGroup_namePrefix\|TestAccRDSParameterGroup_generatedName' PKG=rds
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/rds/... -v -count 1 -parallel 20  -run=TestAccRDSParameterGroup_basic\|TestAccRDSParameterGroup_namePrefix\|TestAccRDSParameterGroup_generatedName -timeout 360m
2024/12/19 09:00:39 Initializing Terraform AWS Provider...
=== RUN   TestAccRDSParameterGroup_basic
=== PAUSE TestAccRDSParameterGroup_basic
=== RUN   TestAccRDSParameterGroup_namePrefix
=== PAUSE TestAccRDSParameterGroup_namePrefix
=== RUN   TestAccRDSParameterGroup_generatedName
=== PAUSE TestAccRDSParameterGroup_generatedName
=== CONT  TestAccRDSParameterGroup_basic
=== CONT  TestAccRDSParameterGroup_generatedName
=== CONT  TestAccRDSParameterGroup_namePrefix
--- PASS: TestAccRDSParameterGroup_generatedName (13.55s)
--- PASS: TestAccRDSParameterGroup_namePrefix (16.11s)
--- PASS: TestAccRDSParameterGroup_basic (34.73s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	40.087s

[johnsonaj]

LGTM 🚀

[ewbankkit]

@sp-jcberleur Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.82.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!