-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add registry policy scope support for aws_ecr_account_setting #40772
feat: Add registry policy scope support for aws_ecr_account_setting #40772
Conversation
Community NoteVoting for Prioritization
For Submitters
|
cc5aee4
to
d20f7f8
Compare
d20f7f8
to
860a985
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccECRAccountSetting_serial' PKG=ecr
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ecr/... -v -count 1 -parallel 20 -run=TestAccECRAccountSetting_serial -timeout 360m
2025/01/06 09:37:23 Initializing Terraform AWS Provider...
=== RUN TestAccECRAccountSetting_serial
=== PAUSE TestAccECRAccountSetting_serial
=== CONT TestAccECRAccountSetting_serial
=== RUN TestAccECRAccountSetting_serial/basic
=== RUN TestAccECRAccountSetting_serial/registryPolicyScope
--- PASS: TestAccECRAccountSetting_serial (38.75s)
--- PASS: TestAccECRAccountSetting_serial/basic (19.81s)
--- PASS: TestAccECRAccountSetting_serial/registryPolicyScope (18.94s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ecr 44.203s
@acwwat Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.83.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
This PR is to add support for setting registry policy scope via appropriate values for the
name
andvalue
argument in theaws_ecr_account_setting
resource.Relations
Closes #40705
References
Referred to PutAccountSetting for specs and wordings.
Output from Acceptance Testing