Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/chatbot_teams_channel_configuration: Fix SNS topic ARNs ordering #40291

Merged
merged 5 commits into from
Nov 25, 2024

Conversation

johnsonaj
Copy link
Contributor

Description

Changes to autflex so that list ordering is not considered a diff.

Best effort changes since we do not have a teams application configured

Relations

Relates #40253

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/chatbot Issues and PRs that pertain to the chatbot service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Nov 25, 2024
@johnsonaj johnsonaj changed the title r/chatbot_teams_channel_configuration: Fix SNS topic ARNs ordering in Slack channel configuration r/chatbot_teams_channel_configuration: Fix SNS topic ARNs ordering Nov 25, 2024
@johnsonaj johnsonaj marked this pull request as ready for review November 25, 2024 14:58
@johnsonaj johnsonaj requested a review from a team as a code owner November 25, 2024 14:58
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@johnsonaj johnsonaj merged commit 788e669 into main Nov 25, 2024
44 checks passed
@johnsonaj johnsonaj deleted the f-chatbot_teams_configuration branch November 25, 2024 16:09
@github-actions github-actions bot added this to the v5.78.0 milestone Nov 25, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Nov 25, 2024
Copy link

This functionality has been released in v5.78.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service/chatbot Issues and PRs that pertain to the chatbot service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants