Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add provisioned_poller_config for kafka in lambda event source … #40303

Merged
merged 11 commits into from
Nov 27, 2024
Merged

feat: add provisioned_poller_config for kafka in lambda event source … #40303

merged 11 commits into from
Nov 27, 2024
+195 −6

Conversation

lvthillo
Copy link
Contributor

@lvthillo lvthillo commented Nov 25, 2024 •
edited
Loading

Description

AWS Lambda announces Provisioned Mode for event source mappings (ESMs) that subscribe to Apache Kafka event sources, a feature that allows you to optimize the throughput of your Kafka ESM by provisioning event polling resources that remain ready to handle sudden spikes in traffic.

Relations

Closes #40293

References

Output from Acceptance Testing

% make testacc TESTS=TestAccLambdaEventSourceMapping_msk PKG=lambda
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/lambda/... -v -count 1 -parallel 20 -run='TestAccLambdaEventSourceMapping_msk'  -timeout 360m
2024/11/25 22:58:40 Initializing Terraform AWS Provider...
=== RUN   TestAccLambdaEventSourceMapping_msk
=== PAUSE TestAccLambdaEventSourceMapping_msk
=== RUN   TestAccLambdaEventSourceMapping_mskWithEventSourceConfig
=== PAUSE TestAccLambdaEventSourceMapping_mskWithEventSourceConfig
=== CONT  TestAccLambdaEventSourceMapping_msk
=== CONT  TestAccLambdaEventSourceMapping_mskWithEventSourceConfig
--- PASS: TestAccLambdaEventSourceMapping_mskWithEventSourceConfig (2211.13s)
--- PASS: TestAccLambdaEventSourceMapping_msk (2232.84s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lambda     2252.791s


% make testacc TESTS=TestAccLambdaEventSourceMapping_selfManagedKafka PKG=lambda
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/lambda/... -v -count 1 -parallel 20 -run='TestAccLambdaEventSourceMapping_selfManagedKafka'  -timeout 360m
2024/11/26 07:46:29 Initializing Terraform AWS Provider...
=== RUN   TestAccLambdaEventSourceMapping_selfManagedKafka
=== PAUSE TestAccLambdaEventSourceMapping_selfManagedKafka
=== RUN   TestAccLambdaEventSourceMapping_selfManagedKafkaWithEventSourceConfig
=== PAUSE TestAccLambdaEventSourceMapping_selfManagedKafkaWithEventSourceConfig
=== CONT  TestAccLambdaEventSourceMapping_selfManagedKafka
=== CONT  TestAccLambdaEventSourceMapping_selfManagedKafkaWithEventSourceConfig
--- PASS: TestAccLambdaEventSourceMapping_selfManagedKafkaWithEventSourceConfig (58.67s)
--- PASS: TestAccLambdaEventSourceMapping_selfManagedKafka (62.19s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lambda     86.648s
...

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/lambda Issues and PRs that pertain to the lambda service. needs-triage Waiting for first response or review from a maintainer. labels Nov 25, 2024
@lvthillo lvthillo marked this pull request as ready for review November 26, 2024 07:34
@lvthillo lvthillo requested a review from a team as a code owner November 26, 2024 07:34
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 27, 2024
@ewbankkit ewbankkit self-assigned this Nov 27, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 27, 2024
@ewbankkit
Tweak CHANGELOG entry.
51c8c4d
@ewbankkit
Tidy up.
868da5d
@ewbankkit
Merge branch 'main' into HEAD
ec8dab5 
# Conflicts:
#	internal/service/lambda/event_source_mapping.go
#	internal/service/lambda/event_source_mapping_test.go
#	website/docs/r/lambda_event_source_mapping.html.markdown
ewbankkit
ewbankkit previously approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccLambdaEventSourceMapping_Kinesis_basic\|TestAccLambdaEventSourceMapping_msk\|TestAccLambdaEventSourceMapping_selfManagedKafka' PKG=lambda ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/lambda/... -v -count 1 -parallel 4  -run=TestAccLambdaEventSourceMapping_Kinesis_basic\|TestAccLambdaEventSourceMapping_msk\|TestAccLambdaEventSourceMapping_selfManagedKafka -timeout 360m
2024/11/27 11:51:22 Initializing Terraform AWS Provider...
=== RUN   TestAccLambdaEventSourceMapping_Kinesis_basic
=== PAUSE TestAccLambdaEventSourceMapping_Kinesis_basic
=== RUN   TestAccLambdaEventSourceMapping_msk
=== PAUSE TestAccLambdaEventSourceMapping_msk
=== RUN   TestAccLambdaEventSourceMapping_mskWithEventSourceConfig
=== PAUSE TestAccLambdaEventSourceMapping_mskWithEventSourceConfig
=== RUN   TestAccLambdaEventSourceMapping_selfManagedKafka
=== PAUSE TestAccLambdaEventSourceMapping_selfManagedKafka
=== RUN   TestAccLambdaEventSourceMapping_selfManagedKafkaWithEventSourceConfig
=== PAUSE TestAccLambdaEventSourceMapping_selfManagedKafkaWithEventSourceConfig
=== RUN   TestAccLambdaEventSourceMapping_selfManagedKafkaWithProvisionedPollerConfig
=== PAUSE TestAccLambdaEventSourceMapping_selfManagedKafkaWithProvisionedPollerConfig
=== CONT  TestAccLambdaEventSourceMapping_Kinesis_basic
=== CONT  TestAccLambdaEventSourceMapping_selfManagedKafka
=== CONT  TestAccLambdaEventSourceMapping_mskWithEventSourceConfig
=== CONT  TestAccLambdaEventSourceMapping_msk
--- PASS: TestAccLambdaEventSourceMapping_selfManagedKafka (45.29s)
=== CONT  TestAccLambdaEventSourceMapping_selfManagedKafkaWithProvisionedPollerConfig
--- PASS: TestAccLambdaEventSourceMapping_Kinesis_basic (66.76s)
=== CONT  TestAccLambdaEventSourceMapping_selfManagedKafkaWithEventSourceConfig
--- PASS: TestAccLambdaEventSourceMapping_selfManagedKafkaWithEventSourceConfig (33.60s)
--- PASS: TestAccLambdaEventSourceMapping_selfManagedKafkaWithProvisionedPollerConfig (56.29s)
--- PASS: TestAccLambdaEventSourceMapping_msk (3071.22s)
--- PASS: TestAccLambdaEventSourceMapping_mskWithEventSourceConfig (3073.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	3078.719s

gdavison
gdavison previously approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few non-blocking comments on the tests and documentation, otherwise looks good!

--- PASS: TestAccLambdaEventSourceMapping_selfManagedKafka (39.43s)
--- PASS: TestAccLambdaEventSourceMapping_selfManagedKafkaWithEventSourceConfig (46.39s)
--- PASS: TestAccLambdaEventSourceMapping_selfManagedKafkaWithProvisionedPollerConfig (61.20s)

internal/service/lambda/event_source_mapping_test.go Show resolved Hide resolved
website/docs/r/lambda_event_source_mapping.html.markdown Outdated Show resolved Hide resolved
internal/service/lambda/event_source_mapping_test.go Show resolved Hide resolved
internal/service/lambda/event_source_mapping_test.go Outdated Show resolved Hide resolved
@ewbankkit ewbankkit dismissed stale reviews from gdavison and themself via 3e1864c November 27, 2024 19:56
@ewbankkit
Copy link
Contributor

After addressing review comments:

% make testacc TESTARGS='-run=TestAccLambdaEventSourceMapping_selfManagedKafka' PKG=lambda 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/lambda/... -v -count 1 -parallel 20  -run=TestAccLambdaEventSourceMapping_selfManagedKafka -timeout 360m
2024/11/27 15:07:40 Initializing Terraform AWS Provider...
=== RUN   TestAccLambdaEventSourceMapping_selfManagedKafka
=== PAUSE TestAccLambdaEventSourceMapping_selfManagedKafka
=== RUN   TestAccLambdaEventSourceMapping_selfManagedKafkaWithEventSourceConfig
=== PAUSE TestAccLambdaEventSourceMapping_selfManagedKafkaWithEventSourceConfig
=== RUN   TestAccLambdaEventSourceMapping_selfManagedKafkaWithProvisionedPollerConfig
=== PAUSE TestAccLambdaEventSourceMapping_selfManagedKafkaWithProvisionedPollerConfig
=== CONT  TestAccLambdaEventSourceMapping_selfManagedKafka
=== CONT  TestAccLambdaEventSourceMapping_selfManagedKafkaWithProvisionedPollerConfig
=== CONT  TestAccLambdaEventSourceMapping_selfManagedKafkaWithEventSourceConfig
--- PASS: TestAccLambdaEventSourceMapping_selfManagedKafka (45.92s)
--- PASS: TestAccLambdaEventSourceMapping_selfManagedKafkaWithEventSourceConfig (46.80s)
--- PASS: TestAccLambdaEventSourceMapping_selfManagedKafkaWithProvisionedPollerConfig (58.46s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	63.893s

@ewbankkit
Copy link
Contributor

@lvthillo Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit dd0feab into hashicorp:main Nov 27, 2024
41 checks passed
@github-actions github-actions bot added this to the v5.79.0 milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdavison gdavison gdavison approved these changes

@ewbankkit ewbankkit ewbankkit left review comments

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/lambda Issues and PRs that pertain to the lambda service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.79.0
Development

Successfully merging this pull request may close these issues.

r/aws_lambda_event_source_mapping: Provisioned Mode for Kafka
3 participants
@lvthillo @ewbankkit @gdavison