azurerm_palo_alto_local_rulestack_rule - fix protocol update

[teowa]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

fix update from protocol = "TCP:8080" to protocol_ports = ["TCP:8080", "TCP:8081"], these two properties are mutually exclusive(ConflictsWith in schema, but protocol property has a default value), so we need to set nil in update to avoid API error Both Protocol and ProtPortList cannot be specified

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

make acctests SERVICE="paloalto" TESTARGS="-parallel 5 -run TestAccPaloAltoLocalRule_" TESTTIMEOUT='2h'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/paloalto -parallel 5 -run TestAccPaloAltoLocalRule_ -timeout 2h -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccPaloAltoLocalRule_basic
=== PAUSE TestAccPaloAltoLocalRule_basic
=== RUN   TestAccPaloAltoLocalRule_requiresImport
=== PAUSE TestAccPaloAltoLocalRule_requiresImport
=== RUN   TestAccPaloAltoLocalRule_withDestination
=== PAUSE TestAccPaloAltoLocalRule_withDestination
=== RUN   TestAccPaloAltoLocalRule_complete
=== PAUSE TestAccPaloAltoLocalRule_complete
=== RUN   TestAccPaloAltoLocalRule_update
=== PAUSE TestAccPaloAltoLocalRule_update
=== CONT  TestAccPaloAltoLocalRule_basic
=== CONT  TestAccPaloAltoLocalRule_update
=== CONT  TestAccPaloAltoLocalRule_complete
=== CONT  TestAccPaloAltoLocalRule_requiresImport
=== CONT  TestAccPaloAltoLocalRule_withDestination
--- PASS: TestAccPaloAltoLocalRule_requiresImport (1046.40s)
--- PASS: TestAccPaloAltoLocalRule_basic (1055.87s)
--- PASS: TestAccPaloAltoLocalRule_withDestination (1074.80s)
--- PASS: TestAccPaloAltoLocalRule_complete (1305.17s)
--- PASS: TestAccPaloAltoLocalRule_update (1611.74s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/paloalto      1611.776s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_palo_alto_local_rulestack_rule - fix protocol update [GH-00000]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[catriona-m]

Thanks @teowa this looks good to me - it would be good if we could add more test steps to test switching between protocol and protocol_ports and removing them entirely to ensure all cases will work. Thanks!

[teowa]

@catriona-m , thanks for reviewing this! I have added the test, please kindly take another look.

--- PASS: TestAccPaloAltoLocalRule_basic (1069.17s)
=== CONT  TestAccPaloAltoLocalRule_update
--- PASS: TestAccPaloAltoLocalRule_requiresImport (1070.98s)
--- PASS: TestAccPaloAltoLocalRule_withDestination (1077.01s)
--- PASS: TestAccPaloAltoLocalRule_updateProtocol (1374.80s)
--- PASS: TestAccPaloAltoLocalRule_complete (1388.81s)

--- PASS: TestAccPaloAltoLocalRule_update (1733.14s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/paloalto	2804.863s

[catriona-m]

Thanks @teowa LGTM!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.