Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_redis_cache - review optional and computed #26608

Merged
merged 8 commits into from
Jul 30, 2024
Merged

Conversation

catriona-m
Copy link
Member

@catriona-m catriona-m commented Jul 11, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR removes instances of optional + computed in azurerm_redis_cache or adds a note explaining the usage.

It also deprecates enable_non_ssl_port in favour of non_ssl_port_enabled and deprecates redis_configuration. enable_authentication in favour of redis_configuration. authentication_enabled

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Tests running in TC

@catriona-m catriona-m marked this pull request as draft July 11, 2024 15:55
@catriona-m catriona-m changed the title azurem_redis_cache - review optional and computed azurerm_redis_cache - review optional and computed Jul 11, 2024
@catriona-m catriona-m marked this pull request as ready for review July 25, 2024 09:44
@catriona-m catriona-m requested a review from a team July 25, 2024 09:47
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @catriona-m - Just one comment to take a look at, but otherwise LGTM 👍

@@ -71,6 +72,11 @@ func dataSourceRedisCache() *pluginsdk.Resource {
Computed: true,
},

"non_ssl_port_enabled": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we wrap the schema in the beta flag here to make it easier to find and remove later?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jackofallops - I spotted another TODO that I had missed, if you wouldn't mind having another quick look!

@catriona-m catriona-m merged commit 03e2e0e into main Jul 30, 2024
32 checks passed
@catriona-m catriona-m deleted the cm/ocredis branch July 30, 2024 10:51
@github-actions github-actions bot added this to the v3.114.0 milestone Jul 30, 2024
catriona-m added a commit that referenced this pull request Jul 30, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants