-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_redis_cache
- review optional and computed
#26608
Conversation
azurem_redis_cache
- review optional and computedazurerm_redis_cache
- review optional and computed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @catriona-m - Just one comment to take a look at, but otherwise LGTM 👍
@@ -71,6 +72,11 @@ func dataSourceRedisCache() *pluginsdk.Resource { | |||
Computed: true, | |||
}, | |||
|
|||
"non_ssl_port_enabled": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we wrap the schema in the beta flag here to make it easier to find and remove later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jackofallops - I spotted another TODO that I had missed, if you wouldn't mind having another quick look!
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Community Note
Description
This PR removes instances of optional + computed in
azurerm_redis_cache
or adds a note explaining the usage.It also deprecates
enable_non_ssl_port
in favour ofnon_ssl_port_enabled
and deprecatesredis_configuration. enable_authentication
in favour ofredis_configuration. authentication_enabled
Testing
Tests running in TC