data_source_storage_account_sas doesn't validate dates. Want to PR fix

[lawrencegripper]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Currently the data_source_storage_account_sas allows you to provide invalid dates.

Expected: resource to error if it cannot create a valid SAS token.
Actual: resource creates invalid sas token and causes failure downstream which are harder to debug.

I'd like to submit a PR to add a ValidateFunc for the data fields. Sound good?

https://github.com/terraform-providers/terraform-provider-azurerm/blob/6f4e1e0ccd80b52ee7fae203d92515b4c5088017/azurerm/data_source_storage_account_sas.go#L101-L112

New or Affected Resource(s)

• azurerm_data_source_storage_account_sas

Potential Terraform Configuration

The following will fail as not a US/ISO format date.

data "azurerm_storage_account_sas" "sastoken" {
  connection_string = "${azurerm_storage_account.storage.primary_connection_string}"
  https_only        = true

  resource_types {
    service   = false
    container = false
    object    = true
  }

  services {
    blob  = true
    queue = false
    table = false
    file  = false
  }

  start  = "2019-01-01"
  expiry = "2020-06-31" # This will fail as not US format so doesn't confirm to ISO standard

  permissions {
    read    = true
    write   = false
    delete  = false
    list    = false
    add     = false
    create  = false
    update  = false
    process = false
  }
}

[ghost]

This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.34.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!