Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support logging for managed public zones #10990

Closed
indypinball opened this issue Jan 27, 2022 · 3 comments
Closed

Support logging for managed public zones #10990

indypinball opened this issue Jan 27, 2022 · 3 comments

Comments

@indypinball
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

The dns_managed_zone resource does not have the ability to set if logging is enabled or not. When looking at the documentation of the managedZones api the field is supported by the api

Please update the resource so that enabling logging on public zones can also be made.

New or Affected Resource(s)

  • google_dns_managed_zone

Potential Terraform Configuration

resource "google_dns_managed_zone" "domain" {
  name        = "example-zone"
  dns_name    = "example-${random_id.rnd.hex}.com."
  description = "Example DNS zone"
  dnssec_config {
    state = "on"
  }
  labels = {
    foo = "bar"
  }
  logging = { 
    enabled = true
  }
}

References

https://cloud.google.com/dns/docs/reference/v1/managedZones

@rileykarson rileykarson added this to the Goals milestone Jan 31, 2022
@melinath
Copy link
Collaborator

melinath commented Sep 9, 2022

the top-level field would be cloud_logging_config to match the API better. If kind is required, we would ideally not require users to set it; I'm not sure what that would look like. Requiring users to set it would probably be better than a complex workaround, though.

@melinath
Copy link
Collaborator

melinath commented Sep 9, 2022

b/245982965

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants