Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_container_cluster add support for selecting gateway api channel when creating or updating a GKE cluster #13117

Labels
enhancement forward/review In review; remove label to forward service/container

Comments

@tuunit
Copy link

tuunit commented Nov 26, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

If you want to use the new Gateway API Controller inside your GKE clusters you need to be able to define a channel to be used. By default no channel is selected, therefore the GKE Gateway Controller does not install the necessary CRDs and the GatewayClasses. I would like to raise a pull request for this feature to be added.

New or Affected Resource(s)

  • google_container_cluster

Potential Terraform Configuration

resource "google_container_cluster" "with_gateway_api_config" {
	name               = "my-cluster"
	location           = "us-central1-f"
	initial_node_count = 1
        release_channel {
               channel = "RAPID"
        }
	gateway_api_config {
		channel = "CHANNEL_STANDARD"
	}
      
}

References

Gateway API Documentation: https://cloud.google.com/kubernetes-engine/docs/concepts/gateway-api
SDK Documentation: https://cloud.google.com/sdk/gcloud/reference/container/clusters/create#--gateway-api
GOlang Reference: https://pkg.go.dev/google.golang.org/api/container/v1#GatewayAPIConfig

@tuunit
Copy link
Author

tuunit commented Nov 26, 2022

I already implemented a solution and I'm currently running the test suite and will raise a PR in the magic-modules repository shortly.

@tuunit
Copy link
Author

tuunit commented Nov 26, 2022

Resolved in: GoogleCloudPlatform/magic-modules#6875

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2023
@github-actions github-actions bot added service/container forward/review In review; remove label to forward labels Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.