Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform templates enforce limits that Google API does not #13777

Assignees
Milestone

Comments

@nazir-kabani
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform 0.12 and provider 4.21 for google

Affected Resource(s)

  • google_resource_network_services_edge_cache_service.go

Terraform Configuration Files

"allow_origins": {
	Type:     schema.TypeList,
	Optional: true,
	Description: `Specifies the list of origins that will be allowed to do CORS requests.

l-Allow-Origin response header.`,
	MaxItems: 5,
	Elem: &schema.Schema{
		Type: schema.TypeString,
	},
},

Debug Output

[<!---
Please provide a link to a GitHub Gist containing the complete debug output. Please do NOT paste the debug output in the issue; just paste a link to the Gist.

To obtain the debug output, run terraform apply with the environment variable TF_LOG=DEBUG. See the Terraform documentation on debugging for more information.
--->](https://gist.github.com/nazir-kabani/52cd0673acd640f3de8d98c97caba02a)

Panic Output

NA

Expected Behavior

Google Media CDN supports 25 CORS origins - https://cloud.google.com/media-cdn/docs/reference/rest/v1/projects.locations.edgeCacheServices#corspolicy

User should be able to create media CDN service with upto 25 CORS origins using Terraform code

Actual Behavior

TF limit is restricting users to create edge cache service with more than 5 CORS origins
below restriction with

module is restricting users.

"allow_origins": {
	Type:     schema.TypeList,
	Optional: true,
	Description: `Specifies the list of origins that will be allowed to do CORS requests.

l-Allow-Origin response header.`,
	MaxItems: 5,
	Elem: &schema.Schema{
		Type: schema.TypeString,
	},
},

Steps to Reproduce

Try creating edge cache service with more than 5 CORS origins with Terraform

  1. terraform apply

Important Factoids

N/A

References

NA

@msampathkumar
Copy link
Contributor

Raised PR at GoogleCloudPlatform/magic-modules#7331 for the same.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.