-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate triggers into core? #3849
Comments
+1, learned about vagrant-triggers through your suggestion. Would be really nice to have something like this in the core! |
I agree, this is a pretty common feature. Tagged. |
WOW! I'm really honored you want to merge triggers into core! @mitchellh if and when you feel like, let me know if I can help you in integrating the plugin, I'd be very pleased to do it! |
I think it's worth reflecting a bit about triggers for multi-machine environments. Right now the plugin implements: "Associate this action block, with this event, for this machine(s)" Also useful would be: "Associate this action block, with this event, once for all machines." ie. sort of a "global" trigger One use case: setup (before 'up') and cleanup (after 'destroy') operations that apply cluster wide (eg. alloc/dealloc a subnet resource in aws ec2) instead of for each machine individually. Also: It would be useful to be able to get at state info or other machine metadata from within an action block (Eg. to conditionalize an 'up' associated action based upon created/not_created state.) There may be other stuff too ... but those spring most readily to mind. |
My use case would be to run |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
I think one way to view Vagrant is as a programmable state-machine for VM environments. Viewed as such the ability to attach custom actions triggered to a state transition before, after, or in place of the existing canned vagrant actions is crucial to full programmability.
We do have the vagrant-triggers plugin which seeks fill this hole. It's a nice addition but I see some shortcomings to its embodiment as a plugin:
triggers is a pretty generic concept and central to the state-machine conceptualization - it belongs in the core
People don't alway think to look for a plugin to augment vagrant functionality. Instead they'll glom on some ad hoc solution. Putting functionality in the core gives it more "visibility".
Putting the functionality in the core might help to mitigate the occurrence of inter-plugin compatibility issues such as this triggers are ignored when provider is 'aws' mitchellh/vagrant-aws#233
The text was updated successfully, but these errors were encountered: