Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add exception return code 472 and 473 #220

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Conversation

yanjunding
Copy link
Contributor

https://developer.hashicorp.com/vault/api-docs#http-status-codes

Description

return code 472 and 473 is not able to handle properly while querying the status

Resolves # (issue)

How has this been tested?

Please describe the tests you ran.

@yanjunding yanjunding requested a review from a team July 28, 2023 00:39
@hashicorp-cla
Copy link

hashicorp-cla commented Jul 28, 2023

CLA assistant check
All committers have signed the CLA.

errors.go Show resolved Hide resolved
@averche
Copy link
Collaborator

averche commented Jul 28, 2023

Thanks for the PR @yanjunding!

For the code organization, it probably makes sense to combine this with the previous if check. Feel free to do that or I can do it in a follow up PR :)

@yanjunding
Copy link
Contributor Author

yanjunding commented Jul 28, 2023

@averche feel free to merge.

Had a quick look at the health Response, shall we check Respdoby == nil, instead of checking err == nil?

The response should be returned as long as the response Body is not nil, including all return status

@averche
Copy link
Collaborator

averche commented Jul 28, 2023

Had a quick look at the health Response, shall we check Respdoby == nil, instead of checking err == nil?

The response should be returned as long as the response Body is not nil, including all return status

Did you mean here or in your code?

@averche averche merged commit 81fba62 into hashicorp:main Jul 28, 2023
@averche averche mentioned this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants