Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments to postZephir.pm #35

Open
moseshll opened this issue May 20, 2024 · 1 comment
Open

Add comments to postZephir.pm #35

moseshll opened this issue May 20, 2024 · 1 comment

Comments

@moseshll
Copy link
Contributor

Would be useful to know what each subroutine does, in particular whether it destructively modifies the record.

@aelkiss
Copy link
Member

aelkiss commented May 20, 2024

  • Deletes PST, LOC, SBL fields (lines 284-286) (shelving location?) - Some records do still include these in Zephir output. Looks like some kind of shelving/holding information.

  • Handling for UC "dollar barcodes" - may no longer be needed?

  • Update the 974 r,q,t with rights info: lines 370-374

  • Update the 974$y with rights date used (line 334)

  • Changes the 974$d (for pdus/gfv reversion for downstream processing - hathifiles, full text indexing)

  • Replaces non-ascii characters in control fields (00x) (lines 707-720)

  • clean_json_line - impenetrable - removes tabs & new lines, replaces non-breaking space with regular space; ensures the indicators are either numeric or blank (or tries to - line 612 might be a bug!); replaces invalid subfields with 'a'. (Shouldn't Zephir do this kind of cleaning...?). Doesn't log any of this cleanup.

  • Removes the 974 entirely if the item is suppressed (supp rights code)
    if there are no remaining 974s in the record, then that record should get deleted from the catalog (lines 439-447)

  • Check whether the leader character 5 is set to deleted ('d') & if so change it to 'c' (Does this happen in practice? Should Zephir check this?)

  • Validates the 008 check_008 but doesn't remediate them (Should Zephir be responsible for this?)

  • Validates that the record has a 245 with an a or k subfield (Should Zephir be responsible for this?)

  • outputs some stuff about problems with records that we never look at (Maybe Zephir ought to do this..) -- could see whether some of those error-checking things ever happen in practice by reviewing error logs?

  • load_prefix_map appears to be unused

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants