Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement TV Tropes ID extraction from movie/TV show title #9

Open
4 tasks
havanagrawal opened this issue Oct 4, 2020 · 2 comments
Open
4 tasks

Implement TV Tropes ID extraction from movie/TV show title #9

havanagrawal opened this issue Oct 4, 2020 · 2 comments
Labels
good first issue Good for newcomers hacktoberfest Issues that are good candidates for Hacktobeerfest participants

Comments

@havanagrawal
Copy link
Owner

havanagrawal commented Oct 4, 2020

Problem

Implement the tv_tropes_id function in external_identifier

Prerequisites

  • You know basic git, i.e. how to fork this repo, clone this repo, work on a branch and send a PR
  • You have basic working knowledge of Python
  • You are able to run Python on your machine
  • You are familiar with basic web scraping (example: requests, bs4 (BeautifulSoup), etc)

How to Test

Simply run python3 external_identifier.py and it will run doctests. Ensure that the test for tv_tropes_id passes.

Hints

  • Try searching for some movie on https://tvtropes.org/. What does the URL look like? You can use that to send a GET request.
  • Feel free to add more arguments to the function if they help in increasing the confidence of the returned identifier.
@havanagrawal havanagrawal added good first issue Good for newcomers hacktoberfest Issues that are good candidates for Hacktobeerfest participants labels Oct 4, 2020
@Jaideep07
Copy link

I would like to do this can you assign it to me

@Jaideep07
Copy link

Jaideep07 commented Oct 5, 2020

So basically the function should return the content in the film/moviename ? or just film/moviename (as in tvtropes)

@Jaideep07 Jaideep07 removed their assignment Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Issues that are good candidates for Hacktobeerfest participants
Projects
None yet
Development

No branches or pull requests

2 participants