Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert init scripts to unified import format #7242

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Convert init scripts to unified import format #7242

merged 3 commits into from
Dec 12, 2024

Conversation

akhismat
Copy link
Contributor

@akhismat akhismat commented Nov 29, 2024 •
edited
Loading

Key Changes

1. Local Initialization Scripts

  • Replaced remote script fetching with local file system initialization
  • Added new environment variable WS_INIT_SCRIPTS for scripts location
  • Added volume mount for initialization scripts in Docker setup
  • Removed dependency on GitHub raw content URLs
  • Added new import step type for workspace initialization scripts

2. Related Changes in Import Functionality

  • Added support for drawings on attached images
  • Added support for emojis in projects and teamspaces
  • Improved file upload error handling with proper success/failure types
  • Added ability to update default project settings
  • Improved logging during initialization

Configuration Changes

Environment Variables

- INIT_SCRIPT_URL=https://raw.githubusercontent.com/...
+ INIT_REPO_DIR=/init-scripts
+ WS_INIT_SCRIPTS=../../init

Docker Volume Mount

services:
  workspace:
    volumes:
      - ${WS_INIT_SCRIPTS}:/init-scripts

Related PR with the scripts: hcengineering/init#6

@akhismat akhismat force-pushed the import-when-init branch 4 times, most recently from f89ba04 to 2955272 Compare December 3, 2024 15:33
@akhismat akhismat marked this pull request as ready for review December 3, 2024 15:51
@akhismat akhismat force-pushed the import-when-init branch 2 times, most recently from 1f679db to 7887ff4 Compare December 4, 2024 05:20
@haiodo haiodo added the do not merge yet In case PR is ok but please do not merge it yet label Dec 4, 2024
@akhismat akhismat mentioned this pull request Dec 4, 2024
Open
@akhismat akhismat force-pushed the import-when-init branch 2 times, most recently from 022522e to 88bd552 Compare December 10, 2024 12:21
@akhismat akhismat requested a review from aonnikov December 11, 2024 06:17
aonnikov
aonnikov previously approved these changes Dec 11, 2024
View reviewed changes
packages/importer/src/huly/unified.ts Show resolved Hide resolved
@haiodo haiodo removed the do not merge yet In case PR is ok but please do not merge it yet label Dec 11, 2024
@akhismat akhismat merged commit 57ee462 into develop Dec 12, 2024
10 checks passed
@akhismat akhismat deleted the import-when-init branch December 12, 2024 11:11
haiodo added a commit that referenced this pull request Dec 12, 2024
@haiodo
Revert "Init scripts with unified import format (#7242)"
751e234 
This reverts commit 57ee462.

Signed-off-by: Andrey Sobolev <[email protected]>
haiodo added a commit that referenced this pull request Dec 12, 2024
@haiodo
Reapply "Init scripts with unified import format (#7242)"
0808e49 
This reverts commit 751e234.

Signed-off-by: Andrey Sobolev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aonnikov aonnikov aonnikov approved these changes

@haiodo haiodo Awaiting requested review from haiodo

@BykhovDenis BykhovDenis Awaiting requested review from BykhovDenis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akhismat @aonnikov @haiodo