Skip to content
This repository has been archived by the owner on Feb 28, 2023. It is now read-only.

Add Sidekiq integration for delayed execution #7

Open
nadavshatz opened this issue Mar 21, 2016 · 3 comments
Open

Add Sidekiq integration for delayed execution #7

nadavshatz opened this issue Mar 21, 2016 · 3 comments

Comments

@nadavshatz
Copy link

This would be a great option to have.

Yes - I am aware of the fact that timing would be off if this happens, but this could still be worth it so the request to Heap is not blocking execution.

@nadavshatz
Copy link
Author

For now I ended up resolving it using this in my initializer:
Heap.class.__send__(:include, Sidekiq::Extensions::Klass)
And then using Heap.delay.track

For some reason - the Sidekiq extensions fail to work on their own. Not sure why.

@pwnall
Copy link
Contributor

pwnall commented Mar 24, 2016

This request seems very reasonable to me. Sadly, I don't have any experience with Sidekiq, and I don't have the time to investigate it right now. I'll leave this issue open, and hope to get to it at some point.

Please let me know if an update accidentally breaks your workaround.

@andyt
Copy link

andyt commented Dec 14, 2016

I don't think delayed execution is the responsibility of this library.

It's trivial to call Heap.track within an appropriate delayed job class for whatever implementation the end user has in their app - Sidekiq, Resque, ActiveJob, etc.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

3 participants