Skip to content

Commit

Permalink
Pass TranslatorManager through DI in order to have access to it in co…
Browse files Browse the repository at this point in the history
…nfigure function of the command (#3763)
  • Loading branch information
LOBsTerr authored and jmolivas committed Feb 17, 2018
1 parent 0c47f84 commit 7df301b
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 3 deletions.
4 changes: 2 additions & 2 deletions config/services/generate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ services:
- { name: drupal.command }
console.generate_form:
class: Drupal\Console\Command\Generate\FormBaseCommand
arguments: ['@console.extension_manager', '@console.form_generator', '@console.chain_queue', '@console.string_converter', '@console.validator', '@plugin.manager.element_info', '@router.route_provider']
arguments: ['@console.translator_manager', '@console.extension_manager', '@console.form_generator', '@console.chain_queue', '@console.string_converter', '@console.validator', '@plugin.manager.element_info', '@router.route_provider']
tags:
- { name: drupal.command }
console.generate_form_alter:
Expand All @@ -56,7 +56,7 @@ services:
- { name: drupal.command }
console.generate_form_config:
class: Drupal\Console\Command\Generate\ConfigFormBaseCommand
arguments: ['@console.extension_manager', '@console.form_generator', '@console.string_converter', '@console.validator', '@router.route_provider', '@plugin.manager.element_info', '@app.root', '@console.chain_queue']
arguments: ['@console.translator_manager', '@console.extension_manager', '@console.form_generator', '@console.string_converter', '@console.validator', '@router.route_provider', '@plugin.manager.element_info', '@app.root', '@console.chain_queue']
tags:
- { name: drupal.command }
console.generate_plugin_type_annotation:
Expand Down
5 changes: 4 additions & 1 deletion src/Command/Generate/ConfigFormBaseCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
use Drupal\Console\Extension\Manager;
use Drupal\Console\Core\Utils\ChainQueue;
use Drupal\Console\Utils\Validator;
use Drupal\Console\Utils\TranslatorManager;
use Drupal\Core\Routing\RouteProviderInterface;
use Drupal\Core\Render\ElementInfoManager;

Expand Down Expand Up @@ -60,6 +61,7 @@ class ConfigFormBaseCommand extends FormCommand
/**
* ConfigFormBaseCommand constructor.
*
* @param TranslatorManager $translator
* @param Manager $extensionManager
* @param FormGenerator $generator
* @param StringConverter $stringConverter
Expand All @@ -70,6 +72,7 @@ class ConfigFormBaseCommand extends FormCommand
* @param ChainQueue $chainQueue
*/
public function __construct(
TranslatorManager $translator,
Manager $extensionManager,
FormGenerator $generator,
StringConverter $stringConverter,
Expand All @@ -87,7 +90,7 @@ public function __construct(
$this->elementInfoManager = $elementInfoManager;
$this->appRoot = $appRoot;
$this->chainQueue = $chainQueue;
parent::__construct($extensionManager, $generator, $chainQueue, $stringConverter, $validator, $elementInfoManager, $routeProvider);
parent::__construct($translator, $extensionManager, $generator, $chainQueue, $stringConverter, $validator, $elementInfoManager, $routeProvider);
}

protected function configure()
Expand Down
4 changes: 4 additions & 0 deletions src/Command/Generate/FormCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
namespace Drupal\Console\Command\Generate;

use Drupal\Console\Command\Shared\ArrayInputTrait;
use Drupal\Console\Utils\TranslatorManager;
use Drupal\Console\Utils\Validator;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
Expand Down Expand Up @@ -74,6 +75,7 @@ abstract class FormCommand extends ContainerAwareCommand
/**
* FormCommand constructor.
*
* @param TranslatorManager $translator
* @param Manager $extensionManager
* @param FormGenerator $generator
* @param ChainQueue $chainQueue
Expand All @@ -83,6 +85,7 @@ abstract class FormCommand extends ContainerAwareCommand
* @param RouteProviderInterface $routeProvider
*/
public function __construct(
TranslatorManager $translator,
Manager $extensionManager,
FormGenerator $generator,
ChainQueue $chainQueue,
Expand All @@ -91,6 +94,7 @@ public function __construct(
ElementInfoManager $elementInfoManager,
RouteProviderInterface $routeProvider
) {
$this->setTranslator($translator);
$this->extensionManager = $extensionManager;
$this->generator = $generator;
$this->chainQueue = $chainQueue;
Expand Down

0 comments on commit 7df301b

Please sign in to comment.