-
-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[multisite:new] argument 'uri' is un-used. #3508
Comments
command:name
] multisite:new argument 'uri' is un-used.
I'm struggling to understand the purpose of that commit - mapping the directory name to itself is obviously not correct, and I don't see how it fixes anything it was supposed to fix. However, the original code was also wrong, and it doesn't seem trivial. Just as you say: The correct syntax of the array key in I suspect the best fix would be reverting the bad commit, and renaming the "URI" to a more accurate "mask" argument: As a convenient feature, if no mask is given, the command could interactively list suggestions based on the value of a Eg:
(Note that there are very many possible values here, including some that are very unlikely like |
PR #3232 solves one problem leaving the functionality half broken. Currently there is no way to create aliases to I suppose due to why it was originally done (#3197) it can't be simply overwritten, but maybe creating 2 aliases could solve this? Around here we would create 2 aliases instead of the one that apparently breaks chainability. |
Hi there, I'm a bit baffled by the PR #3232 and the reason it was merged into the code base. It seems to me that the doc is faulty there. It gives the impression that you should use a It also gives the impression that a new site should reside in the vendor directory, which is kind of misleading too. Would it be possible, without creating a service as elaborate as @cburschka-pwc proposes, to just revert the PR and let the end user call the command with whatever he likes as a uri. Correct me if I'm wrong, but there is a whole comment section in the That being said, having a mask parameter would be great to. |
[
command:name
] multisite:new argument 'uri' is un-used.Problem/Motivation
multisite:new documentation
When passing the second argument to the second parameter, it is unused by src/Command/Multisite/NewCommand.php. What happens is that the first argument, the sites directory, is used for both key and value of sites.php.
Details to include:
How to reproduce
drupal multisite:new my_site_dir my_site_uri
When finished, sites.php should contain an entry with my_site_dir as key and value.
Details to include:
Solution
Revert this commit
Update the documentation to reference how keys of sites.php are created.
The text was updated successfully, but these errors were encountered: