Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[site:status] Configuration directory with unescaped string. #3955

Closed
GuidoRobertone opened this issue Oct 16, 2018 · 5 comments
Closed

[site:status] Configuration directory with unescaped string. #3955

GuidoRobertone opened this issue Oct 16, 2018 · 5 comments
Milestone

Comments

@GuidoRobertone
Copy link
Contributor

Problem/Motivation

The result of site status command returns an unescaped config directory string when the settings.php file was edit.

How to reproduce

  1. Set config directory as $config_directories['sync'] = '../config/sync';
    screenshot_2018-10-15_23-14-53
  2. run drupal site:status
  3. An unescaped string is shown (Configuration directory: sync)
    screenshot_2018-10-15_22-50-48

Details to include:

  • Drupal version : 8.5.6
  • Console version : 1.8.0
  • Console Launcher version : 1.8.0

Solution

A correct directory string will be displayed using strip_tags() function.

@LOBsTerr LOBsTerr added this to the 1.9.0 milestone Oct 16, 2018
@LOBsTerr
Copy link
Member

@GuidoRobertone First of all I have checked the code

$systemData['system'][$title] = strip_tags($requirement['value']);

Tags striping is there.
I have tried to reproduce this, but unfortunately I'm not able.
When I run this command I don't see Configuration directory information there.
I even installed lighting profile and still it is not there.
The only difference there I have Drupal 8.6.1

@LOBsTerr LOBsTerr removed this from the 1.9.0 milestone Oct 17, 2018
@LOBsTerr
Copy link
Member

@GuidoRobertone Ok, After debugging how Drupal displays system requirements. I was able to reproduce it. Actually, the config directory should exist in order to see in system requirements. In my case these folders were there. OK, now I see and I will debug it.

@LOBsTerr
Copy link
Member

PR - #3958
ok, I wrapped titles to strip_tags and it will solve the current issue, but we still issue with data now there will be no value for Configuration directory, because of a bug I have just found

https://www.drupal.org/project/drupal/issues/3007260

I think we also should display description as additional information. I need to find to present it nice way.
Anyway, it could be done in a separate ticket

@LOBsTerr
Copy link
Member

@GuidoRobertone I also added description information, like this users will see more additional information.

@LOBsTerr LOBsTerr added this to the 1.9.0 milestone Oct 17, 2018
@LOBsTerr
Copy link
Member

LOBsTerr commented Apr 5, 2019

Merged

@LOBsTerr LOBsTerr closed this as completed Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants