Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to gracefully quit the game on demand #59

Closed
hecrj opened this issue Jun 21, 2019 · 1 comment · Fixed by #79
Closed

Allow to gracefully quit the game on demand #59

hecrj opened this issue Jun 21, 2019 · 1 comment · Fixed by #79
Labels
feature New feature or request
Milestone
0.4.0

Comments

@hecrj
Copy link
Owner

hecrj commented Jun 21, 2019

As of now, the only way to gracefully quit a Game after Game::run is to implement Game::on_close_request and wait for a close request.

However, it is very common in games to have a UI option to "Quit the game". While we can use std::process::exit, it's not ideal as it doesn't gracefully stop the execution.

Therefore, I think we need to rethink the Game API a bit to allow graceful quits on demand.
@hecrj hecrj added the feature New feature or request label Jun 21, 2019
@hecrj hecrj added this to the 0.4.0 milestone Jul 8, 2019
@hecrj
Copy link
Owner Author

hecrj commented Jul 8, 2019

This should probably be tackled once #62 is merged.

@hecrj hecrj mentioned this issue Aug 5, 2019
Merged
@hecrj hecrj closed this as completed in #79 Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
0.4.0
Development

Successfully merging a pull request may close this issue.

Add Game::is_finished and support graceful quits hecrj/coffee
1 participant
@hecrj