Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time for a rewrite? #10

Open
Hypercubed opened this issue Mar 8, 2019 · 4 comments
Open

Time for a rewrite? #10

Hypercubed opened this issue Mar 8, 2019 · 4 comments

Comments

@Hypercubed
Copy link
Collaborator

Not sure how much this is used but maybe time for a rewrite. If acceptable I would like to:

  • Update deps
  • Dump support for old node versions
  • Remove grunt and the grunt tasks
  • Use es6 or TS.

Thoughts/objections?

@heff
Copy link
Owner

heff commented Mar 8, 2019

I have no objections to that.

@gkatsev is this still used for anything video.js related? And if so any thoughts?

@gkatsev
Copy link
Collaborator

gkatsev commented Apr 22, 2019

I don't think we really use it anywhere in Video.js anymore. If this is still useful to people, I don't have objections to updating it and what not, though, I would prefer to avoid typescript.

@Hypercubed
Copy link
Collaborator Author

I may be the only one to use it! I'll do an update if and when I have time... I'll leave it CJS.

@gkatsev
Copy link
Collaborator

gkatsev commented Apr 22, 2019

We moved to conventional changelog for videojs.

Feel free to upgrade to es6 and es modules. And if you really prefer TS, don't let me stop you since I'm no longer using this 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants