Recursive macro stuck in loop / stack overflow

[Zoybean]

Summary

Being used to vim keybindings, I accidentally pressed q to end a recording instead of Q. Doing this a second time after finishing recording the first macro resulted in the program freezing, presumably replaying the now-recursive macro.

The first time this occurred, the program remained frozen for several minutes until I killed it with kill <PID>. Attempting to reproduce the issue, I made a smaller macro, which ended up immediately overflowing the stack.

Reproduction Steps

I tried this:

1. hx
2. QqQq

I expected this to happen:

• Helix prevents me from recording a recursive macro

Instead, this happened:

• Helix crashes due to stack overflow

Helix log

No response

Platform

Linux (Ubuntu on WSL)

Terminal Emulator

Windows Terminal Version: 1.12.10982.0

Helix Version

22.03-121-g6de2e763

[gavynriebau]

I encountered the same bug and have raised a PR with a fix in #2647.

There are some additional scenarios that could also trigger the crash, for example:

"aQ"bqQ"bQ"aqQ"aq

The above sequence can be described as

1. start recording into register 'a'
2. replay register 'b'
3. end recording into register 'a'
4. start recording into register 'b'
5. replay register 'a'
6. stop recording into register 'b'
7. replay register 'a'

Sequences of commands like the above generated an infinite loop because one macro would replay a second macro which would attempt to replay the first macro...

[archseer]

Closed by #2647