Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open file on line/col #551

Closed
dsseng opened this issue Aug 6, 2021 · 4 comments · Fixed by #445
Closed

Open file on line/col #551

dsseng opened this issue Aug 6, 2021 · 4 comments · Fixed by #445
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements

Comments

@dsseng
Copy link
Contributor

dsseng commented Aug 6, 2021

Describe your feature request

Helix should parse file open commands and params like src/main.rs:15:8 for opening files on specific place. This can be convenient to fix errors reported by tools, since user won't need to find that place manually, :o /path/to/file:line:col would be enough to get right to the needed file location.

URI's are probably great thing to handle as well, maybe in another PR to avoid chaos.

I can take any of those two once it's considered to be a useful feature.

@dsseng dsseng added the C-enhancement Category: Improvements label Aug 6, 2021
@sudormrfbin
Copy link
Member

#445 is a take on this.

@sudormrfbin sudormrfbin linked a pull request Aug 6, 2021 that will close this issue
@dsseng
Copy link
Contributor Author

dsseng commented Aug 6, 2021

Oh, great! Definitely a useful feature.

@pickfire
Copy link
Contributor

pickfire commented Aug 7, 2021

Ah, I realized someone else wanted the same feature as me. I will gladly push the PR. There is just bug left such that if multiple file/pos is specified, only the first one would work, the rest does not work, not quite sure how to fix it yet.

@dsseng
Copy link
Contributor Author

dsseng commented Aug 7, 2021

I can take a look at the code if you want and when I have time.

@kirawi kirawi added the A-helix-term Area: Helix term improvements label Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants