typing twice.

[leedonhyun]

Summary

hi.
keyboard keys being entered twice each time the key is pressed

Reproduction Steps

I tried this:

1. hx

I expected this to happen:

Instead, this happened:

Helix log

~/.cache/helix/helix.log

please provide a copy of `~/.cache/helix/helix.log` here if possible, you may need to redact some of the lines

Platform

window

Terminal Emulator

PowerShell 7.3.2

Helix Version

helix 22.12 (8dab8a0)

[markus-bauer]

Perhaps someone didn't implement the changes in the new crossterm correctly:
crossterm-rs/crossterm#752

AFAIK, crossterm will now report events for press and release:
crossterm-rs/crossterm#745

[soenkekrusche]

I just built hx from source and this kinda drives me away. Does an older build fix this? Or do we have to pick an older crossterm dependency when building?

[markus-bauer]

@soenkekrusche

I really haven't looked into this, it was just a suspicion.
If this is indeed the source of the problem, then it was introduced in crossterm 0.26: https://github.com/crossterm-rs/crossterm/releases/tag/0.26

[David-Else]

@soenkekrusche The commit to use Crossterm 0.26.x was only pushed 10 hours ago, just build from the last commit before which is a976786 . I am sure the problem will be fixed very soon, don't get driven away!

Here is my install script that uses a specific commit, you can see how it works:

    mkdir -p "$helix_src_folder"
    git clone https://github.com/helix-editor/helix "$helix_src_folder"
    git -C "$helix_src_folder" checkout 715c4b24d94c9e2fa70d5d59ce658b89fbde0392 # hand picked stable point
    cargo install --locked --path "$helix_src_folder"/helix-term
    ...

[the-mikedavis]

Could you give #6139 (a8c0705) a try? You can cargo run on that branch so that you don't have to compile the editor in release mode.

[soenkekrusche]

Could you give #6139 (a8c0705) a try? You can cargo run on that branch so that you don't have to compile the editor in release mode.

No more duplicate symbols when typing, built the branch with cargo v 1.63, tested on cmd and powershell 🙂

[leedonhyun]

Could you give #6139 (a8c0705) a try? You can cargo run on that branch so that you don't have to compile the editor in release mode.

Thank you.

[kirawi]

Let's keep this open until the PR gets merged.