Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version-control status bar element doesn't have spacing #6408

Closed
cd-a opened this issue Mar 22, 2023 · 2 comments
Closed

version-control status bar element doesn't have spacing #6408

cd-a opened this issue Mar 22, 2023 · 2 comments
Labels
C-bug Category: This is a bug

Comments

@cd-a
Copy link
Contributor

cd-a commented Mar 22, 2023

Summary

Just tested the version-control element on the status bar that was added in #5682.

It seems to be the only element that lacks spacing before and after. I tested it with the other elements, and those do provide spacing. (like you can see on left element)

Reproduction Steps

config.toml on master:

[editor.statusline]
left = ["mode", "spinner", "version-control"]
center = ["file-name"]
right = ["diagnostics", "selections", "separator", "position", "separator", "file-line-ending", "separator", "file-type", "file-encoding"]
separator = ""

I expected this to happen:
Spacing between spinner and version-control

Instead, this happened:
image

This also happens on the right side.

Helix log

No response

Platform

macOS 13.2.1

Terminal Emulator

kitty 0.27.1

Helix Version

22.12-466-gf9a25a7e

@cd-a cd-a added the C-bug Category: This is a bug label Mar 22, 2023
@pascalkuthe
Copy link
Member

pascalkuthe commented Mar 22, 2023

I believe that most statusline elements don't have spacing these days and that you are supposed to use the spacer element for that

@cd-a
Copy link
Contributor Author

cd-a commented Mar 22, 2023

Thanks, missed the spacer element. Works like a charm now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug
Projects
None yet
Development

No branches or pull requests

2 participants