Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haskell highlighting breaks when using syntax for injective type families #8321

Closed
bramvdbogaerde opened this issue Sep 18, 2023 · 1 comment · Fixed by #8558
Closed

Haskell highlighting breaks when using syntax for injective type families #8321

bramvdbogaerde opened this issue Sep 18, 2023 · 1 comment · Fixed by #8558
Labels
A-language-support Area: Support for programming/text languages C-bug Category: This is a bug E-has-instructions Call for participation: Has instructions for fixing the issue and opening a PR

Comments

@bramvdbogaerde
Copy link

Summary

Note: I'm not sure if this is the right place to create this issue, since it is probably also tree-sitter related.

Helix does not highlight the syntax used for injective type families correctly. In fact, it causes the syntax highlighting for the remainder of the document to break.

Helix highlighting (incorrect):

afbeelding

(note that everything starting from line 4 is highlighted incorrectly)

Neovim highlighting (correct):
afbeelding

Reproduction Steps

N/A

Helix log

N/A

Platform

macOS

Terminal Emulator

iTerm

Helix Version

helix 23.05 (7f5940b)

@bramvdbogaerde bramvdbogaerde added the C-bug Category: This is a bug label Sep 18, 2023
@the-mikedavis
Copy link
Member

It looks like this snippet breaks the haskell tree-sitter parser on the version we're pinned at:

helix/languages.toml

Lines 979 to 981 in 7fa5f34

[[grammar]]
name = "haskell"
source = { git = "https://github.com/tree-sitter/tree-sitter-haskell", rev = "98fc7f59049aeb713ab9b72a8ff25dcaaef81087" }

The latest commit in https://github.com/tree-sitter/tree-sitter-haskell parses the snippet correctly and should produce the proper highlights, so we just need to update the commit and queries (runtime/queries/haskell/*.scm).

@the-mikedavis the-mikedavis added E-has-instructions Call for participation: Has instructions for fixing the issue and opening a PR A-language-support Area: Support for programming/text languages labels Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages C-bug Category: This is a bug E-has-instructions Call for participation: Has instructions for fixing the issue and opening a PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants